public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: gregkh@linuxfoundation.org, conor+dt@kernel.org,
	 linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org,  matthias.bgg@gmail.com, linux@roeck-us.net,
	heikki.krogerus@linux.intel.com,  cy_huang@richtek.com,
	linux-arm-kernel@lists.infradead.org,  chunfeng.yun@mediatek.com,
	linux-mediatek@lists.infradead.org,  devicetree@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names
Date: Fri, 19 Jan 2024 05:49:10 -0600	[thread overview]
Message-ID: <170566494967.3600611.15278394895468454608.robh@kernel.org> (raw)
In-Reply-To: <20240119094105.98312-1-angelogioacchino.delregno@collabora.com>


On Fri, 19 Jan 2024 10:41:04 +0100, AngeloGioacchino Del Regno wrote:
> This IP has only one interrupt, hence interrupt-names is not necessary
> to have.
> Since there is no user yet, simply remove interrupt-names.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml        | 5 -----
>  1 file changed, 5 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.example.dtb: mt6360@34: tcpc: 'interrupt-names' is a required property
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6360.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.example.dtb: tcpc: 'interrupt-names' is a required property
	from schema $id: http://devicetree.org/schemas/usb/mediatek,mt6360-tcpc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/mediatek,mt6360.example.dtb: pmic@34: tcpc: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6360.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/mediatek,mt6360.example.dtb: tcpc: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/usb/mediatek,mt6360-tcpc.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240119094105.98312-1-angelogioacchino.delregno@collabora.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2024-01-19 11:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19  9:41 [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names AngeloGioacchino Del Regno
2024-01-19  9:41 ` [PATCH v2 2/2] usb: typec: tcpci_mt6360: Retrieve interrupt by index AngeloGioacchino Del Regno
2024-01-19 11:49 ` Rob Herring [this message]
2024-01-19 16:32 ` [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names Conor Dooley
2024-01-22 10:32   ` AngeloGioacchino Del Regno
2024-01-23 17:14     ` Conor Dooley
2024-01-24  8:48       ` AngeloGioacchino Del Regno
2024-01-24 16:18         ` Conor Dooley
2024-01-25 10:32         ` Krzysztof Kozlowski
2024-01-25 11:41           ` AngeloGioacchino Del Regno
2024-01-25 16:57             ` Conor Dooley
2024-01-25 17:02               ` Conor Dooley
2024-01-26  9:15                 ` AngeloGioacchino Del Regno
2024-01-26  9:27                   ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170566494967.3600611.15278394895468454608.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=conor+dt@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox