public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>
Cc: devicetree@vger.kernel.org, andersson@kernel.org,
	 linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
	 krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@linaro.org,
	 robh+dt@kernel.org, kernel@quicinc.com, conor+dt@kernel.org,
	 linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: qcom: consolidate functions
Date: Tue, 23 Jan 2024 21:39:10 -0600	[thread overview]
Message-ID: <170606754969.2856906.5067146308427582194.robh@kernel.org> (raw)
In-Reply-To: <20240124023305.15755-3-quic_tengfan@quicinc.com>


On Wed, 24 Jan 2024 10:33:05 +0800, Tengfei Fan wrote:
> Functions are consolidated in SM4450 tlmm driver, also consolidate these
> functions in SM4450 tlmm binding file.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  .../bindings/pinctrl/qcom,sm4450-tlmm.yaml    | 51 +++++++------------
>  1 file changed, 17 insertions(+), 34 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml:83:60: [warning] too many spaces after comma (commas)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240124023305.15755-3-quic_tengfan@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


      parent reply	other threads:[~2024-01-24  3:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  2:33 [PATCH 0/2] dt-bindings: pinctrl: qcom: update SM4450 pinctrl Tengfei Fan
2024-01-24  2:33 ` [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name Tengfei Fan
2024-01-24  3:33   ` Dmitry Baryshkov
2024-01-25  1:18     ` Tengfei Fan
2024-01-25  1:20       ` Dmitry Baryshkov
2024-01-25  1:35         ` Tengfei Fan
2024-01-24  6:38   ` Krzysztof Kozlowski
2024-01-24  8:07     ` Dmitry Baryshkov
2024-01-24  8:46       ` Krzysztof Kozlowski
2024-01-25  1:27         ` Tengfei Fan
2024-01-24  2:33 ` [PATCH 2/2] dt-bindings: pinctrl: qcom: consolidate functions Tengfei Fan
2024-01-24  3:34   ` Dmitry Baryshkov
2024-01-25  1:37     ` Tengfei Fan
2024-01-24  3:39   ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170606754969.2856906.5067146308427582194.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@quicinc.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_tengfan@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox