From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Feng Kan <fkan@apm.com>,
patches@apm.com, devicetree@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH V3 2/4] i2c: busses: xgene: add acpi support for i2c xgene SLIMpro driver
Date: Fri, 24 Apr 2015 09:28:40 +0200 [thread overview]
Message-ID: <17062291.7gO4LEY2iX@wuerfel> (raw)
In-Reply-To: <1429812430-31631-3-git-send-email-fkan@apm.com>
On Thursday 23 April 2015 11:07:08 Feng Kan wrote:
>
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id xgene_slimpro_i2c_acpi_ids[] = {
> + {"PRP0001", 0},
> + {}
> +};
> +MODULE_DEVICE_TABLE(acpi, slimpro_acpi_ids);
> +#endif
>
Sorry, but this is wrong: The PRP0001 name is meant for embedded
devices that just use the generic properties API for loading, and
does not require specifying an ACPI device ID.
Arnd
next prev parent reply other threads:[~2015-04-24 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 18:07 [PATCH V3 0/4] i2c: busses: xgene: I2C proxy driver for X-Gene Feng Kan
2015-04-23 18:07 ` [PATCH V3 1/4] i2c: busses: add SLIMpro I2C device driver on APM X-Gene platform Feng Kan
2015-04-23 18:07 ` [PATCH V3 2/4] i2c: busses: xgene: add acpi support for i2c xgene SLIMpro driver Feng Kan
2015-04-24 7:28 ` Arnd Bergmann [this message]
[not found] ` <1429812430-31631-1-git-send-email-fkan-qTEPVZfXA3Y@public.gmane.org>
2015-04-23 18:07 ` [PATCH V3 3/4] Documentation: i2c: Add APM X-Gene platform SLIMpro I2C driver documentation Feng Kan
2015-04-23 18:07 ` [PATCH V3 4/4] arm64: dts: add proxy I2C device driver on APM X-Gene platform Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17062291.7gO4LEY2iX@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=fkan@apm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).