* [PATCH] dt-bindings: mux: restrict node name suffixes
@ 2024-01-09 8:25 Krzysztof Kozlowski
2024-01-09 15:23 ` Peter Rosin
2024-02-05 16:15 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-09 8:25 UTC (permalink / raw)
To: Peter Rosin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Rob Herring
Make the pattern matching node names a bit stricter to improve DTS
consistency. The pattern is restricted to -N suffixes to decimal
numbers.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Some time ago I did such change treewide, but mux was left out:
https://lore.kernel.org/all/20230530144851.92059-1-krzysztof.kozlowski@linaro.org/
---
Documentation/devicetree/bindings/mux/mux-controller.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mux/mux-controller.yaml b/Documentation/devicetree/bindings/mux/mux-controller.yaml
index 8b943082a241..571ad9e13ecf 100644
--- a/Documentation/devicetree/bindings/mux/mux-controller.yaml
+++ b/Documentation/devicetree/bindings/mux/mux-controller.yaml
@@ -74,7 +74,7 @@ select:
properties:
$nodename:
- pattern: '^mux-controller(@.*|-[0-9a-f]+)?$'
+ pattern: '^mux-controller(@.*|-([0-9]|[1-9][0-9]+))?$'
'#mux-control-cells':
enum: [ 0, 1 ]
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: mux: restrict node name suffixes
2024-01-09 8:25 [PATCH] dt-bindings: mux: restrict node name suffixes Krzysztof Kozlowski
@ 2024-01-09 15:23 ` Peter Rosin
2024-01-09 15:32 ` Peter Rosin
2024-02-05 16:15 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Peter Rosin @ 2024-01-09 15:23 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, devicetree, linux-kernel
Cc: Rob Herring
Hi!
2024-01-09 at 09:25, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to -N suffixes to decimal
> numbers.
Maybe I'm confused, but how is that compatible with the hex I2C
address in Documentation/devicetree/bindings/mux/adi,adg792a.txt?
&i2c0 {
mux: mux-controller@50 {
compatible = "adi,adg792a";
Cheers,
Peter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: mux: restrict node name suffixes
2024-01-09 15:23 ` Peter Rosin
@ 2024-01-09 15:32 ` Peter Rosin
0 siblings, 0 replies; 4+ messages in thread
From: Peter Rosin @ 2024-01-09 15:32 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, devicetree, linux-kernel
Cc: Rob Herring
2024-01-09 at 16:23, Peter Rosin wrote:
> Hi!
>
> 2024-01-09 at 09:25, Krzysztof Kozlowski wrote:
>> Make the pattern matching node names a bit stricter to improve DTS
>> consistency. The pattern is restricted to -N suffixes to decimal
>> numbers.
>
> Maybe I'm confused, but how is that compatible with the hex I2C
> address in Documentation/devicetree/bindings/mux/adi,adg792a.txt?
>
> &i2c0 {
> mux: mux-controller@50 {
> compatible = "adi,adg792a";
I'm was indeed confused. The @-tail is .* and the decimal digits have
nothing to do with the address. Sorry for the noise...
Acked-by: Peter Rosin <peda@axentia.se>
Cheers,
Peter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mux: restrict node name suffixes
2024-01-09 8:25 [PATCH] dt-bindings: mux: restrict node name suffixes Krzysztof Kozlowski
2024-01-09 15:23 ` Peter Rosin
@ 2024-02-05 16:15 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2024-02-05 16:15 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Conor Dooley, linux-kernel, Rob Herring, devicetree, Peter Rosin,
Krzysztof Kozlowski
On Tue, 09 Jan 2024 09:25:11 +0100, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to -N suffixes to decimal
> numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Some time ago I did such change treewide, but mux was left out:
> https://lore.kernel.org/all/20230530144851.92059-1-krzysztof.kozlowski@linaro.org/
> ---
> Documentation/devicetree/bindings/mux/mux-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-05 16:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-09 8:25 [PATCH] dt-bindings: mux: restrict node name suffixes Krzysztof Kozlowski
2024-01-09 15:23 ` Peter Rosin
2024-01-09 15:32 ` Peter Rosin
2024-02-05 16:15 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).