From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: kernel test robot <lkp@intel.com>,
bchihi@baylibre.com, daniel.lezcano@linaro.org,
angelogioacchino.delregno@collabora.com, rafael@kernel.org,
amitk@kernel.org, rui.zhang@intel.com, matthias.bgg@gmail.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
rdunlap@infradead.org, ye.xingchen@zte.com.cn,
p.zabel@pengutronix.de
Cc: oe-kbuild-all@lists.linux.dev, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
khilman@baylibre.com, james.lo@mediatek.com,
rex-bc.chen@mediatek.com
Subject: Re: [PATCH v12] thermal: drivers: mediatek: Add the Low Voltage Thermal Sensor driver
Date: Wed, 1 Feb 2023 08:47:43 +0100 [thread overview]
Message-ID: <17072296-c1fb-1e82-65fd-26b448167087@linaro.org> (raw)
In-Reply-To: <202302011058.17Vvc1pN-lkp@intel.com>
On 01/02/2023 04:09, kernel test robot wrote:
> Hi Balsam,
>
> Thank you for the patch! Yet something to improve:
>
>
>
> url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20230131-234122/bchihi-baylibre-com/thermal-drivers-mediatek-Relocate-driver-to-mediatek-folder/20230124-211910
> base: the 4th patch of https://lore.kernel.org/r/20230124131717.128660-5-bchihi%40baylibre.com
> patch link: https://lore.kernel.org/r/20230131153816.21709-1-bchihi%40baylibre.com
> patch subject: [PATCH v12] thermal: drivers: mediatek: Add the Low Voltage Thermal Sensor driver
> config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20230201/202302011058.17Vvc1pN-lkp@intel.com/config)
> compiler: s390-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/5646ebf6f10ff0fc60c04d8c57523f7c44526b41
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review UPDATE-20230131-234122/bchihi-baylibre-com/thermal-drivers-mediatek-Relocate-driver-to-mediatek-folder/20230124-211910
> git checkout 5646ebf6f10ff0fc60c04d8c57523f7c44526b41
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>>> drivers/thermal/mediatek/lvts_thermal.c:20:10: fatal error: dt-bindings/thermal/mediatek,lvts-thermal.h: No such file or directory
> 20 | #include <dt-bindings/thermal/mediatek,lvts-thermal.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
So here is your driver... and you decided not only to make reviewers
life more difficult, but also to fail all automated tools.
No, that's not how patchsets should be sent. You have here clear
dependency, you cannot send them separately.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-01 7:48 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 13:17 [PATCH v11 0/6] Add LVTS thermal architecture bchihi
2023-01-24 13:17 ` [PATCH v11 1/6] thermal/drivers/mediatek: Relocate driver to mediatek folder bchihi
2023-01-24 15:37 ` AngeloGioacchino Del Regno
2023-01-25 15:02 ` Balsam CHIHI
2023-01-24 13:17 ` [PATCH v11 2/6] dt-bindings/thermal/mediatek: Add LVTS thermal controllers dt-binding definition bchihi
2023-01-25 11:14 ` Daniel Lezcano
2023-01-25 20:35 ` Rob Herring
2023-01-25 21:13 ` Daniel Lezcano
2023-01-25 20:34 ` Rob Herring
2023-01-26 10:33 ` Balsam CHIHI
2023-01-26 16:10 ` [PATCH v12 2/6] dt-bindings: thermal: mediatek: " bchihi
2023-01-27 22:10 ` Daniel Lezcano
2023-01-28 10:50 ` Krzysztof Kozlowski
2023-01-30 10:49 ` Balsam CHIHI
2023-01-28 10:48 ` Krzysztof Kozlowski
2023-01-30 10:40 ` Balsam CHIHI
2023-01-30 11:18 ` Matthias Brugger
2023-01-30 12:19 ` Balsam CHIHI
2023-01-30 16:07 ` Matthias Brugger
2023-01-31 16:53 ` Krzysztof Kozlowski
2023-01-31 17:01 ` Daniel Lezcano
2023-01-31 14:04 ` [PATCH v3] dt-bindings: thermal: mediatek: Add LVTS thermal controllers bchihi
2023-02-01 7:46 ` Krzysztof Kozlowski
2023-02-01 13:34 ` Balsam CHIHI
2023-02-01 13:37 ` Krzysztof Kozlowski
2023-02-01 13:56 ` Balsam CHIHI
2023-03-07 13:42 ` [PATCH] thermal/drivers/mediatek/lvts_thermal: fix memcpy's number of bytes in lvts_calibration_init() bchihi
2023-03-08 9:10 ` AngeloGioacchino Del Regno
2023-03-09 12:37 ` Dan Carpenter
2023-01-24 13:17 ` [PATCH v11 3/6] arm64/dts/mt8195: Add efuse node to mt8195 bchihi
2023-01-25 14:25 ` Matthias Brugger
2023-01-25 15:04 ` Balsam CHIHI
2023-01-24 13:17 ` [PATCH v11 4/6] thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver bchihi
2023-01-24 15:31 ` AngeloGioacchino Del Regno
2023-01-25 15:06 ` Balsam CHIHI
2023-01-31 15:38 ` [PATCH v12] thermal: drivers: mediatek: " bchihi
2023-02-01 3:09 ` kernel test robot
2023-02-01 7:47 ` Krzysztof Kozlowski [this message]
2023-02-01 15:14 ` Balsam CHIHI
2023-02-01 7:55 ` Krzysztof Kozlowski
2023-02-01 16:46 ` Balsam CHIHI
2023-02-01 16:59 ` Matthias Brugger
2023-02-03 10:35 ` Balsam CHIHI
2023-02-01 17:12 ` Krzysztof Kozlowski
2023-02-03 11:06 ` Balsam CHIHI
2023-02-06 14:07 ` Daniel Lezcano
2023-02-06 14:30 ` Krzysztof Kozlowski
2023-02-06 14:38 ` Daniel Lezcano
2023-02-06 14:32 ` Balsam CHIHI
2023-01-24 13:17 ` [PATCH v11 5/6] arm64/dts/mt8195: Add thermal zones and thermal nodes bchihi
2023-01-24 15:36 ` AngeloGioacchino Del Regno
2023-01-25 15:10 ` Balsam CHIHI
2023-01-25 19:09 ` Matthias Brugger
2023-01-26 9:43 ` Balsam CHIHI
2023-01-31 15:37 ` [PATCH v12] arm64: dts: mediatek: mt8195: " bchihi
2023-01-24 13:17 ` [PATCH v11 6/6] arm64/dts/mt8195: Add temperature mitigation threshold bchihi
2023-01-24 15:36 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17072296-c1fb-1e82-65fd-26b448167087@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amitk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bchihi@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.lo@mediatek.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).