From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13195306B0D for ; Thu, 20 Nov 2025 07:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763623931; cv=none; b=HP74Ribh7U2H4AtP38qU5swtDePhWVolSo7LUWtk/E8/cvy1dKM5VTMmFL8P2reMeeXAy5ltiqRxNT0XRKDk7NM1JhgYl9rDRCtF12PIdYdd6qCa95gj9n9tv2/pNsQVSlTUTyuMzo2QCJjsxex8Oi8azJR/lATyvI0jD5/hvps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763623931; c=relaxed/simple; bh=HQxLahnb/gBuYP24U4BNPYZhJMAzzZLw9A4kBEhJKZk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NH6bASYgKJ4JWNZzX70GMXwDrorMS5JCfD0Ipb5VTdasVSWJUbJiPwvf0ibVZJ8CaYsaigd6jyC7RjEvrR/tTcvAzDj/nwbFLZnGHIwrk3uq+6EJ43JHD9HXyafZXHo/he17/V004JRNNlLXRytgIZsUQ6DTKFMyrpN+lDiHX+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fPD/cmlI; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fPD/cmlI" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-29845b06dd2so7340585ad.2 for ; Wed, 19 Nov 2025 23:32:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763623928; x=1764228728; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IovJKqNa1DO/xBfd+tkVMUbaKlyIIus8shUO1PQ/Pck=; b=fPD/cmlIb4onK2E0gJJmTMNuKPhpH54hl9jAEPD9tMNB23MttbHp/gsGigyptVVGPH Fk3BAf6/1f7agezcGjfVMUtmuE5uSl1muD0GDa/rjRswYrGO4dyoUVIwIF8FDXIbIBjT d05IOc+8vuWQZF3xYE+OHFIlzHbMBPsRWBxb2OopTTL7RfJAOYCT8DOaXr/K/PW+UOBn Ys1Q7BCUl8BPwsLvEgXL2BYyG1CWkJ13vqkw0/3aa2LKUnKNtg97NP9K0k4NwXPiJzpw RpbocmBaWT9Dx0h2oiufUW6y3xDopDIWaAewCtIp8SF3v8g+KEDBku6o2tcqkFP6sJXG YebQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763623928; x=1764228728; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IovJKqNa1DO/xBfd+tkVMUbaKlyIIus8shUO1PQ/Pck=; b=c/bvHEONaONOHQS5cKhL/kWDCSuRhFZZtHalZIvTqOdBMyHJ09win49uOmVYo/wBVO gHCon3qWxFIDB5Pj/FgVVAYrqSsGxgvQNCC0jiZKsgVPcz1gzrKOz4DwOh50aov7Pd0O wUvu9VKUzbkGhO9DX0zBlehRGqjPY5UuExJjdSKubTD74KvYAcO2hEdRI2w4s5F6zsv6 gZFchUYbY64Rdpse9jz9zdn8DhAece/UbtOqOQB1TlcSH7ulO8LXtTliY1UCmpsRK7+c /o1kbXkHoBJhG041vZxyWQHlyJNc9GsQbubhGspkZQyJJXehH6Yc3TYiQdwvvnPulLg7 i1Vg== X-Forwarded-Encrypted: i=1; AJvYcCVzLF7rUBJzBCmcIx5bRpG35rQZyxl3neih7OVw2+WlcQWdBAeSP2jI7xuWF4Y5XN+H4+au8CMDgjyX@vger.kernel.org X-Gm-Message-State: AOJu0YzFbcd6mILkqyWIIhNx4CQPH36llnniQn+/zNPG6MXhCX8v8ZWu p67X+A2CVtk/sr2QrLC5bxghuvtb69K1H11Ka2kxc0cv8SNdOaPzKSYy X-Gm-Gg: ASbGnct0OseaI7NSvMlhnjyD3VAzepOHYuID/3ekuhZ3pLIqbuct7LTUzl+qriD5a8e pqjhJq7rd/H2zA28yuWV9yTLvYWbFYvTDNOye1BuOtiI2iYqfoYZnqiAPWDGP5kON6WbfufRkx7 y0miQqEWoD0MAyV0tuIKzivsKQrMlZhYG3DVByFGhFE8pv9Osz1rEkHT/ZyzbUJ6CfUMcsS2lOb 81plWjlV2h/KBmaOJRkjrmSjyknv7hbhjOIwH9ncKm/smdlZSx+sYBptbubPXtocfHQmle3k22P RvGELmRzfw/4Ll3Sfin6EZYzvjTijbi20QIuUeR5ARMX07nwGovNqiKTMRxEMjgwsO+fDOGHj02 QqNDAQJbPnTd76ZiGvEcbW4AFORa/USNcTt85BmZT0Q/7bxgjaeDzoAhGLKdvrmtodoDEA3g6/d I8zUB8k5SP35RjEPDy+rJpg9e5QnvBrBNb X-Google-Smtp-Source: AGHT+IGQUWwZZOJMzDFqMgtCjzZHr9EOao8nq9sPmN3CCmFh9PBvE4vkHnI80FQz0hKEEZBlamifGQ== X-Received: by 2002:a17:903:110f:b0:295:57f6:768 with SMTP id d9443c01a7336-29b5b10799cmr28830025ad.33.1763623928199; Wed, 19 Nov 2025 23:32:08 -0800 (PST) Received: from [172.16.20.12] ([167.103.23.36]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b1075ddsm16559445ad.3.2025.11.19.23.32.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 23:32:07 -0800 (PST) Message-ID: <17085f43-22fc-4590-bf42-6869ca3d7bd3@gmail.com> Date: Thu, 20 Nov 2025 13:02:39 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board To: Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251118130814.3554333-1-tessolveupstream@gmail.com> <20251118130814.3554333-3-tessolveupstream@gmail.com> Content-Language: en-US From: tessolveupstream@gmail.com In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 19-11-2025 15:55, Dmitry Baryshkov wrote: > On Tue, Nov 18, 2025 at 06:38:14PM +0530, Sudarshan Shetty wrote: >> Add the device tree for the QCS615-based Talos EVK platform. The >> platform is composed of a System-on-Module following the SMARC >> standard, and a Carrier Board. >> >> The Carrier Board supports several display configurations, HDMI and >> LVDS. Both configurations use the same base hardware, with the display >> selection controlled by a DIP switch. >> >> To avoid duplication, use an include file, talos-evk-cb.dtsi, which >> defines the interfaces and peripherals common to both display >> variants. Two additional DTs (e.g. talos-evk and talos-evk-lvds) >> can describe the selected display configuration. >> >> The initial device tree includes support for: >> - CPU and memory >> - UART >> - GPIOs >> - Regulators >> - PMIC >> - Early console >> - AT24MAC602 EEPROM >> - MCP2515 SPI to CAN >> - ADV7535 DSI-to-HDMI bridge >> - DisplayPort interface > > You got the question for v6, responded there but didn't update commit > message. What is not enabled here? E.g. why isn't venus enabled? In earlier patch, we have added 'Wi-Fi/BT and ethernet is not supported'as a commit message. Later,based on Krzysztof Kozlowski’s review comments, we removed the same. Please find the below review comment for your reference. https://lore.kernel.org/all/20251028053248.723560-1-tessolveupstream@gmail.com/T/#mda58996a7abac13780f8ce2cd49b84c32d4c50a6 We are not clear whether 'Wi-Fi/BT and ethernet is not supported' should be added back to the commit message or not. Could you please confirm your preference? Venus is enabled in this patch. > >> Signed-off-by: Sudarshan Shetty >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++ >> arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/talos-evk.dts | 94 ++++ >> 4 files changed, 598 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi >> create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts >> >