From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A418353A6; Mon, 4 Mar 2024 06:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709534208; cv=none; b=uw+2/rGqWR6Fyi3Wd2NraA70Yo2CHlktY2s9zAiWMe6xp0cJ36wt1f4RchQdK6/epJ7EVbpYFNUDIPQFyrLhID/BawpH7ubFIx7L5FHXXCLmZwgE/F9rJZm31uiuGZZQRhAUq/xKWLYM6grR65ljorNR6QmAkAUd8KT0TItFKLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709534208; c=relaxed/simple; bh=Lxit3tCPkuMKtuJFSH+dJUeNvHqA7L8OYQppQC6rPNY=; h=Date:Content-Type:MIME-Version:From:To:Cc:In-Reply-To:References: Message-Id:Subject; b=aDVwQGRdfnsLkE1iWTBKcyZNJI1+PkGAJQMLXzGPmr8caZTOmBsC31xM2W+hF3XOfCk8EgDkwi6vN6c7/S7XT5HaBESiktrjSj1bNORd13I8tcJLaHgbvb1gC5n7/W5IJKPJDBIbGTCBVjmMgz+Gm0CVMDYgToA14nrj2TYWrJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jxriXqJb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jxriXqJb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A2FBC433F1; Mon, 4 Mar 2024 06:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709534208; bh=Lxit3tCPkuMKtuJFSH+dJUeNvHqA7L8OYQppQC6rPNY=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=jxriXqJbBviYoORKOQcXJDUwyJsaZY0CPgW6Oe8TttKAmSvfyE4BQuW25aT/hQlip EycujU65LIlA+jvjSZY2ZFc2IA3AZ63veV7cNkFfzAqebsXNMM25mAA0ujeDDnVhRP rOSIkqhGdiHG3XvfyG3VMIIydikTnGfAupeIzWZNZ0caug7zTU1TtQDmT7h43pJ+Sq jwPiEzucalG88tLoMPULbKYiPL2+V5tsY1ZRNY/L938nJVJhd0CmKXUpSQxmfGvjeC fakbtsn35UIpcUtJ1iirJGZURsxYp2sUxGrHFDwHX6m2aQ2+CT1qDAyeMtb5QNaoue Lepbx/p3VrHzw== Date: Mon, 04 Mar 2024 00:36:46 -0600 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Rob Herring To: Dharma Balasubiramani Cc: Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, Conor Dooley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Thomas Zimmermann , Nicolas Ferre , Maxime Ripard , Alexandre Belloni , Maarten Lankhorst , Daniel Vetter , David Airlie , Claudiu Beznea In-Reply-To: <20240304-lcdc-fb-v2-1-a14b463c157a@microchip.com> References: <20240304-lcdc-fb-v2-1-a14b463c157a@microchip.com> Message-Id: <170953420588.3592333.10799403141422424018.robh@kernel.org> Subject: Re: [PATCH v2] dt-bindings: display: atmel,lcdc: convert to dtschema On Mon, 04 Mar 2024 11:06:39 +0530, Dharma Balasubiramani wrote: > Convert the atmel,lcdc bindings to DT schema. > Changes during conversion: add missing clocks and clock-names properties. > > Signed-off-by: Dharma Balasubiramani > --- > This patch converts the existing lcdc display text binding to JSON schema. > The binding is split into two namely > lcdc.yaml > - Holds the frame buffer properties > lcdc-display.yaml > - Holds the display panel properties which is a phandle to the display > property in lcdc fb node. > > These bindings are tested against the existing at91 dts files using > dtbs_check. > --- > Changes in v2: > - Run checkpatch and remove whitespace errors. > - Add the standard interrupt flags. > - Split the binding into two, namely lcdc.yaml and lcdc-display.yaml. > - Link to v1: https://lore.kernel.org/r/20240223-lcdc-fb-v1-1-4c64cb6277df@microchip.com > --- > .../bindings/display/atmel,lcdc-display.yaml | 98 ++++++++++++++++++++++ > .../devicetree/bindings/display/atmel,lcdc.txt | 87 ------------------- > .../devicetree/bindings/display/atmel,lcdc.yaml | 70 ++++++++++++++++ > 3 files changed, 168 insertions(+), 87 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.example.dtb: display0: 'atmel,dmacon' is a required property from schema $id: http://devicetree.org/schemas/display/atmel,lcdc-display.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.example.dtb: display0: 'atmel,lcdcon2' is a required property from schema $id: http://devicetree.org/schemas/display/atmel,lcdc-display.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.example.dtb: display0: 'atmel,guard-time' is a required property from schema $id: http://devicetree.org/schemas/display/atmel,lcdc-display.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.example.dtb: display0: 'fsl,pcr', 'model' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/display/atmel,lcdc-display.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240304-lcdc-fb-v2-1-a14b463c157a@microchip.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.