From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC/PATCH 2/2] gpio-rcar: Add DT support Date: Sat, 18 May 2013 08:30:23 +0200 Message-ID: <171110063.t2Kcvcq8kf@avalon> References: <1368197317-13169-1-git-send-email-laurent.pinchart@ideasonboard.com> <1368197317-13169-3-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Guennadi Liakhovetski Cc: linux-sh@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Linus Walleij , Magnus Damm List-Id: devicetree@vger.kernel.org Hi Guennadi, On Friday 17 May 2013 14:22:22 Guennadi Liakhovetski wrote: > On Fri, 10 May 2013, Laurent Pinchart wrote: > > Add DT bindings for the gpio-rcar driver and read the device > > configuration from the DT node at probe time if available. > > > > Cc: devicetree-discuss@lists.ozlabs.org > > Signed-off-by: Laurent Pinchart > > --- > > > > .../devicetree/bindings/gpio/renesas,gpio-rcar.txt | 48 +++++++++++++++++ > > drivers/gpio/gpio-rcar.c | 63 +++++++++++++---- > > 2 files changed, 101 insertions(+), 10 deletions(-) > > create mode 100644 > > Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt > Testing this patch reveals, that (at least) one thing is missing here: > > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c > index a499ea6..e233778 100644 > --- a/drivers/gpio/gpio-rcar.c > +++ b/drivers/gpio/gpio-rcar.c > @@ -342,6 +342,7 @@ static int gpio_rcar_probe(struct platform_device *pdev) > gpio_chip->owner = THIS_MODULE; > gpio_chip->base = p->config.gpio_base; > gpio_chip->ngpio = p->config.number_of_pins; > + gpio_chip->dev = &pdev->dev; > > irq_chip = &p->irq_chip; > irq_chip->name = name; Indeed, thank you. I wonder how I managed not to notice this. I'll integrate the modification for v2. -- Regards, Laurent Pinchart