From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Caleb Connolly <caleb.connolly@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [RFT PATCH v2 4/6] arm64: dts: qcom: sdm845: move audio to separate file
Date: Fri, 20 Jan 2023 08:42:08 +0100 [thread overview]
Message-ID: <1711636c-8aa1-eccc-eded-14a64baf7bec@linaro.org> (raw)
In-Reply-To: <46acf2f4-3272-c33d-887f-05d4f4aad4d7@linaro.org>
On 20/01/2023 00:24, Caleb Connolly wrote:
>
>
> On 18/01/2023 10:34, Krzysztof Kozlowski wrote:
>> Re-organize SDM845 sound components into separate, audio DTSI which
>> should be included and customized by the SDM845 boards wanting audio.
>> The DTSI includes:
>> 1. WCD9340 codec node because it is not a property of the SoC, but board.
>> 2. Common sound DAI links, shared with all sound cards.
>
> Hi Krzysztof,
>
> I know I already reported this on IRC, I thought I'd duplicate the info
> here for completeness sake.
>
> Due to how the sound node is parsed the device numbers in alsa are
> derived from the index of the sound/mmX-dai-link child nodes.
>
> For boards which use more than 3 FE's this causes breaking changes in
> userspace, as the slim-dai-link and slimcap-dai-link nodes now come
> before the other mmX-dai-link nodes, for example with my OnePlus 6
> patches "aplay -l" shows:
>
> card 0: O6 [OnePlus 6], device 0: MultiMedia1 (*) []
> Subdevices: 1/1
> Subdevice #0: subdevice #0
> card 0: O6 [OnePlus 6], device 1: MultiMedia2 (*) []
> Subdevices: 1/1
> Subdevice #0: subdevice #0
> card 0: O6 [OnePlus 6], device 2: MultiMedia3 (*) []
> Subdevices: 1/1
> Subdevice #0: subdevice #0
> card 0: O6 [OnePlus 6], device 5: MultiMedia4 (*) [] <-- 5 instead of 3
> Subdevices: 1/1
> Subdevice #0: subdevice #0
> card 0: O6 [OnePlus 6], device 6: MultiMedia5 (*) []
> Subdevices: 1/1
> Subdevice #0: subdevice #0
> card 0: O6 [OnePlus 6], device 7: MultiMedia6 (*) []
> Subdevices: 1/1
> Subdevice #0: subdevice #0
>
> This breaks the UCM configs shipped by postmarketOS and Mobian - though
> none of it is "upstream".
Thanks for the report.
>
> Would it be reasonable to add all 6 FE DAI's and then disable the unused
> ones on a per-board basis?
Or just drop the sound node from the audio DTSI, not sure if there are
benefits in such case...
>
>>
>> The Xiaomi Polaris, although includes WCD9340 codec, it lacks sound
>> node, so it stays disabled.
>>
>> On all others boards not using audio, keep the Slimbus node disabled as
>> it is empty.
Please trim your replies - there is a lot of unrelated content here and
I don't know if I should keep scrolling to look for something or not.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-20 7:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 10:34 [RFT PATCH v2 1/6] arm64: dts: qcom: sdm845-db845c: add generic sound compatible Krzysztof Kozlowski
2023-01-18 10:34 ` [RFT PATCH v2 2/6] arm64: dts: qcom: sdm845-xiaomi-beryllium: " Krzysztof Kozlowski
2023-01-18 10:34 ` [RFT PATCH v2 3/6] arm64: dts: qcom: sdm850-lenovo-yoga: correct " Krzysztof Kozlowski
2023-01-18 10:34 ` [RFT PATCH v2 4/6] arm64: dts: qcom: sdm845: move audio to separate file Krzysztof Kozlowski
2023-01-19 23:24 ` Caleb Connolly
2023-01-20 7:42 ` Krzysztof Kozlowski [this message]
2023-01-20 23:55 ` Caleb Connolly
2023-01-18 10:34 ` [RFT PATCH v2 5/6] arm64: dts: qcom: sdm845-audio-wcd9340: commonize pinctrl Krzysztof Kozlowski
2023-01-18 10:34 ` [RFT PATCH v2 6/6] arm64: dts: qcom: sdm845-audio-wcd9340: commonize clocks Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1711636c-8aa1-eccc-eded-14a64baf7bec@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).