From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08434C05027 for ; Fri, 20 Jan 2023 07:42:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230074AbjATHmO (ORCPT ); Fri, 20 Jan 2023 02:42:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjATHmO (ORCPT ); Fri, 20 Jan 2023 02:42:14 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F43279EA1 for ; Thu, 19 Jan 2023 23:42:12 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id g10so3330602wmo.1 for ; Thu, 19 Jan 2023 23:42:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UmqGa1Qj6D/e9e1ov4dTk2Q4eRwYBsgwn9EnteIfffA=; b=lSVSHakEyMy8miejxoMOivQAdLRndirkBxlQRwNMwUS9+AaabszZi1wslfnxTbNwj4 w4dq0LMC04mABQh2aalyAO/g6xXC3CrqMPPmvgu/JtYt+I7y3jdM3WHSVNEKHT6UkHt6 JlFPfnDeCf0Hxm1MvF4ap6X5YDKvblSw6MmsNewKK/gzhktRPMevWYv2xO/Ffpb542E6 2SI93/kUEupMdm/RXE4spD+DA8at0G9/8APUmMDrI4h/pewFkXggGR2Mx72h3/y4W3x/ f8WPl5Ik8Gh6potgTSLLrRRrGpubPX1qIKtvdzBBg/uV95fXQxIISLAG0eyC2+FAsaxZ tRnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UmqGa1Qj6D/e9e1ov4dTk2Q4eRwYBsgwn9EnteIfffA=; b=woPxPCbOY+cq9YWCazu2H3K/Qo7//kdsFL+pYuHZPj1bN0OHfbx41sqSEPwnsFcVW/ dAbdmGsWnQfjArI6HF1AamXBBR2O4Tql1LGjoVjVLLOuSXUUV+eRBd4i03uTM9Bee+7C UGgAJ2UMfUhjNAWCiVSA9MRgmk9OjcCAtASsoqrQIcpOL6seSFqbcO8NTMAC7lZLgEou yu6eZdLB7xrV7F/lKq/3dFw0YN7/u491jFJJAQi8aw7jbAm2yAiofzeWQJ8N5IMihaG8 HEhSfm0AZ4NZ3eRi6W4yTSqHriLw+NjCRAhE03YHZq2Fm7hnHKeBK1SQYNAZdC+As6sL cS3g== X-Gm-Message-State: AFqh2koHYFseAWP8Q6GIAzJfCf/yF5ru7TiGv1lm7/YscN8gG5gWq84o xJQnTdvz/B++vEJ8S1VAO2AjYw== X-Google-Smtp-Source: AMrXdXvei+KDchpZ4NbLTqiGqPC7s6x89FqKwKhyCBnJ8HqVDA1spAuFTlMYtqEGfGr9PKRbDZbXMg== X-Received: by 2002:a05:600c:3514:b0:3db:80c:8ed9 with SMTP id h20-20020a05600c351400b003db080c8ed9mr11872073wmq.22.1674200530840; Thu, 19 Jan 2023 23:42:10 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id k21-20020a05600c1c9500b003db30be4a54sm1120935wms.38.2023.01.19.23.42.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 23:42:10 -0800 (PST) Message-ID: <1711636c-8aa1-eccc-eded-14a64baf7bec@linaro.org> Date: Fri, 20 Jan 2023 08:42:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [RFT PATCH v2 4/6] arm64: dts: qcom: sdm845: move audio to separate file Content-Language: en-US To: Caleb Connolly , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla References: <20230118103458.107434-1-krzysztof.kozlowski@linaro.org> <20230118103458.107434-4-krzysztof.kozlowski@linaro.org> <46acf2f4-3272-c33d-887f-05d4f4aad4d7@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <46acf2f4-3272-c33d-887f-05d4f4aad4d7@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/01/2023 00:24, Caleb Connolly wrote: > > > On 18/01/2023 10:34, Krzysztof Kozlowski wrote: >> Re-organize SDM845 sound components into separate, audio DTSI which >> should be included and customized by the SDM845 boards wanting audio. >> The DTSI includes: >> 1. WCD9340 codec node because it is not a property of the SoC, but board. >> 2. Common sound DAI links, shared with all sound cards. > > Hi Krzysztof, > > I know I already reported this on IRC, I thought I'd duplicate the info > here for completeness sake. > > Due to how the sound node is parsed the device numbers in alsa are > derived from the index of the sound/mmX-dai-link child nodes. > > For boards which use more than 3 FE's this causes breaking changes in > userspace, as the slim-dai-link and slimcap-dai-link nodes now come > before the other mmX-dai-link nodes, for example with my OnePlus 6 > patches "aplay -l" shows: > > card 0: O6 [OnePlus 6], device 0: MultiMedia1 (*) [] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: O6 [OnePlus 6], device 1: MultiMedia2 (*) [] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: O6 [OnePlus 6], device 2: MultiMedia3 (*) [] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: O6 [OnePlus 6], device 5: MultiMedia4 (*) [] <-- 5 instead of 3 > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: O6 [OnePlus 6], device 6: MultiMedia5 (*) [] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: O6 [OnePlus 6], device 7: MultiMedia6 (*) [] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > > This breaks the UCM configs shipped by postmarketOS and Mobian - though > none of it is "upstream". Thanks for the report. > > Would it be reasonable to add all 6 FE DAI's and then disable the unused > ones on a per-board basis? Or just drop the sound node from the audio DTSI, not sure if there are benefits in such case... > >> >> The Xiaomi Polaris, although includes WCD9340 codec, it lacks sound >> node, so it stays disabled. >> >> On all others boards not using audio, keep the Slimbus node disabled as >> it is empty. Please trim your replies - there is a lot of unrelated content here and I don't know if I should keep scrolling to look for something or not. Best regards, Krzysztof