From: Tomasz Figa <t.figa@samsung.com>
To: Leela Krishna Amudala <l.krishna@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
wim@iguana.be, devicetree@vger.kernel.org, dianders@chromium.org,
linux-watchdog@vger.kernel.org, cpgs@samsung.com,
sachin.kamat@linaro.org
Subject: Re: [PATCH V4 1/3] ARM: dts: Add pmu sysreg node to Exynos5 dtsi file
Date: Wed, 30 Oct 2013 15:42:47 +0100 [thread overview]
Message-ID: <1713455.GWPmumZDIq@amdc1227> (raw)
In-Reply-To: <1383126673-29033-2-git-send-email-l.krishna@samsung.com>
Hi Leela,
On Wednesday 30 of October 2013 15:21:11 Leela Krishna Amudala wrote:
> This patch adds pmusysreg node to Exynos5 dtsi file to handle PMU
> register accesses in a centralized way using syscon driver
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> arch/arm/boot/dts/exynos5.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
> index e52b038..918e732 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -106,4 +106,9 @@
> #size-cells = <0>;
> status = "disabled";
> };
> +
> + pmu_sys_reg: pmusysreg@1004000 {
Please keep the node name generic, syscon should be fine. Also there is
a typo in unit-address suffix. The label could also have a better name,
like pmu_syscon.
Best regards,
Tomasz
> + compatible = "syscon";
> + reg = <0x10040000 0x5000>;
> + };
> };
>
next prev parent reply other threads:[~2013-10-30 14:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 9:51 [PATCH V4 0/3] Add watchdog DT nodes and use syscon regmap interfac to configure pmu registers Leela Krishna Amudala
2013-10-30 9:51 ` [PATCH V4 1/3] ARM: dts: Add pmu sysreg node to Exynos5 dtsi file Leela Krishna Amudala
2013-10-30 9:52 ` Sachin Kamat
2013-10-30 10:09 ` Leela Krishna Amudala
2013-10-30 10:13 ` Sachin Kamat
2013-10-30 11:22 ` Tomasz Figa
2013-10-30 15:26 ` Guenter Roeck
2013-10-30 14:42 ` Tomasz Figa [this message]
2013-10-31 5:29 ` Leela Krishna Amudala
2013-10-30 9:51 ` [PATCH V4 2/3] ARM: dts: add watchdog device nodes for Exynos5250 and Exynos5420 Leela Krishna Amudala
2013-10-30 9:51 ` [PATCH V4 3/3] watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu register Leela Krishna Amudala
2013-10-30 14:39 ` Tomasz Figa
2013-10-31 5:31 ` Leela Krishna Amudala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1713455.GWPmumZDIq@amdc1227 \
--to=t.figa@samsung.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).