From: Diogo Ivo <diogo.ivo@siemens.com>
To: Simon Horman <horms@kernel.org>
Cc: MD Danish Anwar <danishanwar@ti.com>,
Roger Quadros <rogerq@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] net: ti: icssg-prueth: Enable PTP timestamping support for SR1.0 devices
Date: Mon, 3 Jun 2024 11:05:04 +0100 [thread overview]
Message-ID: <171516c6-71a8-4dbb-bf6d-d20cfb55686f@siemens.com> (raw)
In-Reply-To: <20240601120334.GF491852@kernel.org>
Hi Simon,
On 6/1/24 1:03 PM, Simon Horman wrote:
> On Wed, May 29, 2024 at 05:05:10PM +0100, Diogo Ivo wrote:
>> + prueth->iep0 = icss_iep_get_idx(np, 0);
>> + if (IS_ERR(prueth->iep0)) {
>> + ret = dev_err_probe(dev, PTR_ERR(prueth->iep0), "iep0 get failed\n");
>
> Hi Diogo,
>
> A minor nit from my side.
> No need to address this unless there will be a v2 for some other reason.
>
> Networking still prefers code to be 80 columns wide or less.
> It looks like that can be trivially achieved here.
Noted :)
Since I already have to address Sunil's comments on patch 2 I'll change
this one too to comply with the 80 character rule.
Thank you for the review!
Best regards,
Diogo
next prev parent reply other threads:[~2024-06-03 10:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 16:05 [PATCH 0/3] Enable PTP timestamping/PPS for AM65x SR1.0 devices Diogo Ivo
2024-05-29 16:05 ` [PATCH 1/3] net: ti: icssg-prueth: Enable PTP timestamping support for " Diogo Ivo
2024-05-30 18:43 ` Jacob Keller
2024-06-03 9:55 ` Diogo Ivo
2024-06-01 12:03 ` Simon Horman
2024-06-03 10:05 ` Diogo Ivo [this message]
2024-05-29 16:05 ` [PATCH 2/3] net: ti: icss-iep: Enable compare events Diogo Ivo
2024-05-30 18:43 ` Jacob Keller
2024-05-31 5:12 ` [EXTERNAL] " Sunil Kovvuri Goutham
2024-06-02 15:19 ` Andrew Lunn
2024-06-03 10:02 ` Diogo Ivo
2024-05-29 16:05 ` [PATCH 3/3] arm64: dts: ti: iot2050: Add IEP interrupts for SR1.0 devices Diogo Ivo
2024-05-30 18:45 ` Jacob Keller
2024-05-31 6:22 ` [PATCH 0/3] Enable PTP timestamping/PPS for AM65x " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171516c6-71a8-4dbb-bf6d-d20cfb55686f@siemens.com \
--to=diogo.ivo@siemens.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).