From: "Heiko Stübner" <heiko@sntech.de>
To: Nick Xie <xieqinick@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
nick@khadas.com
Subject: Re: [PATCH v2] arm64: dts: rockchip: Add support for Khadas Edge/Edge-V/Captain boards
Date: Fri, 14 Jun 2019 16:01:05 +0200 [thread overview]
Message-ID: <1719008.LxYQEzyXAE@diego> (raw)
In-Reply-To: <CAP4nuTUQZRG9yV1Bz2hpe10K3CrWhVWf_YYBnMs3O1KyahhrMw@mail.gmail.com>
Hi Nick,
Am Freitag, 14. Juni 2019, 15:32:11 CEST schrieb Nick Xie:
> Thanks, I'll check them out.
>
> But there is a small typo:
> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/tree/arch/arm64/boot/dts/rockchip/rk3399-khadas-edge.dtsi?h=v5.3-armsoc/dts64&id=910249897d13beaa0b46069e27139024cd77e916#n299
>
> *22 (GPIO1_C6)* should be *RK_PC6* NOT *RK_PD6*.
thanks for double-checking ... I've updated the commit to use the right gpio now.
Heiko
>
> Heiko Stuebner <heiko@sntech.de> 于2019年6月14日周五 下午7:32写道：
>
> > Am Montag, 10. Juni 2019, 09:57:53 CEST schrieb xieqinick@gmail.com:
> > > From: Nick Xie <nick@khadas.com>
> > >
> > > Add devicetree support for Khadas Edge/Edge-V/Captain boards.
> > > Khadas Edge is an expandable Rockchip RK3399 board with goldfinger.
> > > Khadas Captain is the carrier board for Khadas Edge.
> > > Khadas Edge-V is a Khadas VIM form factor Rockchip RK3399 board.
> > >
> > > Signed-off-by: Nick Xie <nick@khadas.com>
> >
> > applied for 5.3 after doing some style-fixes to the edge.dtsi
> > (2 missing gpio constants, some newlines and sdio-regulator
> > references were missing "<..>")
> >
> > Please double-check the result
> >
> >
> > Thanks
> > Heiko
> >
> >
> >
next prev parent reply other threads:[~2019-06-14 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 9:21 [PATCH] arm64: dts: rockchip: Add support for Khadas Edge/Edge-V/Captain boards xieqinick
2019-06-04 14:08 ` Heiko Stuebner
2019-06-10 7:19 ` Nick Xie
2019-06-14 11:31 ` Heiko Stuebner
2019-06-10 7:57 ` [PATCH v2] " xieqinick
2019-06-14 11:32 ` Heiko Stuebner
2019-06-14 13:32 ` Nick Xie
2019-06-14 14:01 ` Heiko Stübner [this message]
2019-06-14 14:06 ` Nick Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1719008.LxYQEzyXAE@diego \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=nick@khadas.com \
--cc=robh+dt@kernel.org \
--cc=xieqinick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).