* [PATCH] dt-bindings: pinctrl: pinctrl-single: fix schmitt related properties
@ 2024-06-19 23:14 Inochi Amaoto
2024-06-27 21:19 ` Rob Herring (Arm)
2024-07-03 12:46 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Inochi Amaoto @ 2024-06-19 23:14 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Tony Lindgren
Cc: Inochi Amaoto, linux-gpio, devicetree, linux-kernel
The "pinctrl-single,input-schmitt" have four arguments in the bindings
but the driver needs two. According to the meaning of other properties
and driver, it should have "enable" suffix. Fortunately, there is no
dts using this property, so it is safe to correct this property with the
right name.
Rename existed property "pinctrl-single,input-schmitt" to
"pinctrl-single,input-schmitt-enable" and add the right description for
property "pinctrl-single,input-schmitt" used by the driver.
Fixes: 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml")
Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
---
.../devicetree/bindings/pinctrl/pinctrl-single.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
index c11495524dd2..e8177cc1115c 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
@@ -144,6 +144,13 @@ patternProperties:
- description: drive strength mask
pinctrl-single,input-schmitt:
+ description: Optional schmitt strength configuration
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ items:
+ - description: schmitt strength current
+ - description: schmitt strength mask
+
+ pinctrl-single,input-schmitt-enable:
description: Optional input schmitt configuration
$ref: /schemas/types.yaml#/definitions/uint32-array
items:
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: pinctrl: pinctrl-single: fix schmitt related properties
2024-06-19 23:14 [PATCH] dt-bindings: pinctrl: pinctrl-single: fix schmitt related properties Inochi Amaoto
@ 2024-06-27 21:19 ` Rob Herring (Arm)
2024-07-03 12:46 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-06-27 21:19 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Tony Lindgren, Conor Dooley, Linus Walleij, linux-kernel,
Krzysztof Kozlowski, linux-gpio, devicetree
On Thu, 20 Jun 2024 07:14:47 +0800, Inochi Amaoto wrote:
> The "pinctrl-single,input-schmitt" have four arguments in the bindings
> but the driver needs two. According to the meaning of other properties
> and driver, it should have "enable" suffix. Fortunately, there is no
> dts using this property, so it is safe to correct this property with the
> right name.
>
> Rename existed property "pinctrl-single,input-schmitt" to
> "pinctrl-single,input-schmitt-enable" and add the right description for
> property "pinctrl-single,input-schmitt" used by the driver.
>
> Fixes: 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml")
> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> ---
> .../devicetree/bindings/pinctrl/pinctrl-single.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: pinctrl: pinctrl-single: fix schmitt related properties
2024-06-19 23:14 [PATCH] dt-bindings: pinctrl: pinctrl-single: fix schmitt related properties Inochi Amaoto
2024-06-27 21:19 ` Rob Herring (Arm)
@ 2024-07-03 12:46 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2024-07-03 12:46 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Tony Lindgren,
linux-gpio, devicetree, linux-kernel
On Thu, Jun 20, 2024 at 1:15 AM Inochi Amaoto <inochiama@outlook.com> wrote:
> The "pinctrl-single,input-schmitt" have four arguments in the bindings
> but the driver needs two. According to the meaning of other properties
> and driver, it should have "enable" suffix. Fortunately, there is no
> dts using this property, so it is safe to correct this property with the
> right name.
>
> Rename existed property "pinctrl-single,input-schmitt" to
> "pinctrl-single,input-schmitt-enable" and add the right description for
> property "pinctrl-single,input-schmitt" used by the driver.
>
> Fixes: 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml")
> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-03 12:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-19 23:14 [PATCH] dt-bindings: pinctrl: pinctrl-single: fix schmitt related properties Inochi Amaoto
2024-06-27 21:19 ` Rob Herring (Arm)
2024-07-03 12:46 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).