From: "Rob Herring (Arm)" <robh@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: conor+dt@kernel.org, krzk+dt@kernel.org,
quic_kriskura@quicinc.com, linux-kernel@vger.kernel.org,
johan+linaro@kernel.org, andersson@kernel.org,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
konrad.dybcio@linaro.org, gregkh@linuxfoundation.org,
devicetree@vger.kernel.org, quic_wcheng@quicinc.com
Subject: Re: [PATCH v0 1/2] dt-bindings: usb: qcom,dwc3: Add minItems for interrupt info
Date: Thu, 11 Jul 2024 02:31:22 -0600 [thread overview]
Message-ID: <172068668209.928451.13962575882186553669.robh@kernel.org> (raw)
In-Reply-To: <20240711065615.2720367-1-quic_varada@quicinc.com>
On Thu, 11 Jul 2024 12:26:14 +0530, Varadarajan Narayanan wrote:
> IPQ5332 has only three interrupts. Update min items
> accordingly for interrupt names to fix the following
> dt_binding_check errors.
>
> interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
>
> Fixes: a5c7592366af ("dt-bindings: usb: qcom,dwc3: add SC8280XP binding")
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml: allOf:12:then:properties:interrupt-names: {'minItems': 3, 'maxItems': 4, 'items': [{'const': 'pwr_event'}, {'const': 'dp_hs_phy_irq'}, {'const': 'dm_hs_phy_irq'}, {'const': 'ss_phy_irq'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240711065615.2720367-1-quic_varada@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-07-11 8:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 6:56 [PATCH v0 1/2] dt-bindings: usb: qcom,dwc3: Add minItems for interrupt info Varadarajan Narayanan
2024-07-11 6:56 ` [PATCH v0 2/2] arm64: dts: qcom: ipq5332: Fix interrupt trigger type for usb Varadarajan Narayanan
2024-07-11 7:47 ` [PATCH v0 1/2] dt-bindings: usb: qcom,dwc3: Add minItems for interrupt info Krzysztof Kozlowski
2024-07-11 8:47 ` Varadarajan Narayanan
2024-07-11 9:03 ` Krzysztof Kozlowski
2024-07-11 9:03 ` Krzysztof Kozlowski
2024-07-11 9:28 ` Varadarajan Narayanan
2024-07-11 8:31 ` Rob Herring (Arm) [this message]
2024-07-11 14:22 ` Rob Herring
2024-07-17 9:51 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172068668209.928451.13962575882186553669.robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_kriskura@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).