Re: [PATCH 2/2] dt-bindings: Document the Rockchip RK1608 bindings

[Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>]

Hi Leo,

Am Dienstag, 12. Dezember 2017, 14:28:15 CET schrieb Leo Wen:
> +Optional properties:
> +
> +- spi-max-frequency	: Maximum SPI clocking speed of the device;
> +			        (for RK1608)
> +- spi-min-frequency	: Minimum SPI clocking speed of the device;
> +			        (for RK1608)

There is no general spi-min-frequency property specified and I also guess
systems would try to use a frequency close to maximum anyway, so I don't
really see the use of specifying a minimum frequency.


> +&pinctrl {
> +	rk1608_irq_gpios {
> +		rk1608_irq_gpios: rk1608_irq_gpios {
> +			rockchip,pins = <6 2 RK_FUNC_GPIO &pcfg_pull_none>;
> +			rockchip,pull = <1>;
> +		};
> +	};

There is no need to specify the soc-specific pinctrl settings in a general
devicetree example and you're using properties from your vendor-tree
like the rockchip,pull one ... that are not used in the mainline kernel.

So I'd suggest dropping the whole &pinctrl from the example.


Heiko