[PATCH v3 0/2] Fix ipq5332 usb interrupt trigger type

[PATCH v3 0/2] Fix ipq5332 usb interrupt trigger type

[Varadarajan Narayanan]

Trigger type is incorrectly specified as IRQ_TYPE_EDGE_BOTH
instead of IRQ_TYPE_LEVEL_HIGH. This trigger type is not
supported for SPIs and results in probe failure with -EINVAL.

Fix dt_binding_check/dtbs_check errors associated with usb's
interrupts.

v3:
In the previous version, the hunk got mixed up while rebasing.
Update dependency version.

Depends:
[1] https://lore.kernel.org/linux-arm-msm/20240722055539.2594434-1-quic_varada@quicinc.com/

v2:
Depends:
[1] https://lore.kernel.org/linux-arm-msm/20240722055539.2594434-1-quic_varada@quicinc.com/

Varadarajan Narayanan (2):
  dt-bindings: usb: qcom,dwc3: Update ipq5332 interrupt info
  arm64: dts: qcom: ipq5332: Fix interrupt trigger type for usb

 .../devicetree/bindings/usb/qcom,dwc3.yaml        | 15 +++++++++++++++
 arch/arm64/boot/dts/qcom/ipq5332.dtsi             |  4 ++--
 2 files changed, 17 insertions(+), 2 deletions(-)

-- 
2.34.1

[PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Update ipq5332 interrupt info

[Varadarajan Narayanan]

IPQ5332 has only three interrupts. Update the constraints
to fix the following dt_binding_check errors.

	interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short

Fixes: 53c6d854be4e ("dt-bindings: usb: dwc3: Clean up hs_phy_irq in binding")
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
v3: In the previous version, the hunk got mixed up while rebasing.
    Fix that

v2: Fix patch version numbering. Incorrectly marked the first version as v0
    Add interrupts and interrupt-names for ipq5332 instead of clubbing it with
    qcom,x1e80100-dwc3
---
 .../devicetree/bindings/usb/qcom,dwc3.yaml        | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 6c5f962bbcf9..b07d4acc4289 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -443,6 +443,21 @@ allOf:
           contains:
             enum:
               - qcom,ipq5332-dwc3
+    then:
+      properties:
+        interrupts:
+          maxItems: 3
+        interrupt-names:
+          items:
+            - const: pwr_event
+            - const: dp_hs_phy_irq
+            - const: dm_hs_phy_irq
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
               - qcom,x1e80100-dwc3
     then:
       properties:
-- 
2.34.1

[PATCH v3 2/2] arm64: dts: qcom: ipq5332: Fix interrupt trigger type for usb

[Varadarajan Narayanan]

Trigger type is incorrectly specified as IRQ_TYPE_EDGE_BOTH
instead of IRQ_TYPE_LEVEL_HIGH. This trigger type is not
supported for SPIs and results in probe failure with -EINVAL.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Fixes: 927173bf8a0e ("arm64: dts: qcom: Add missing interrupts for qcs404/ipq5332")
Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
 arch/arm64/boot/dts/qcom/ipq5332.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index 7e8f9d578382..71328b223531 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -322,8 +322,8 @@ usb: usb@8af8800 {
 			reg = <0x08af8800 0x400>;
 
 			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>,
-				     <GIC_SPI 53 IRQ_TYPE_EDGE_BOTH>,
-				     <GIC_SPI 52 IRQ_TYPE_EDGE_BOTH>;
+				     <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "pwr_event",
 					  "dp_hs_phy_irq",
 					  "dm_hs_phy_irq";
-- 
2.34.1

Re: [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Update ipq5332 interrupt info

[Rob Herring (Arm)]

On Tue, 23 Jul 2024 15:31:50 +0530, Varadarajan Narayanan wrote:
> IPQ5332 has only three interrupts. Update the constraints
> to fix the following dt_binding_check errors.
> 
> 	interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
> 
> Fixes: 53c6d854be4e ("dt-bindings: usb: dwc3: Clean up hs_phy_irq in binding")
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> v3: In the previous version, the hunk got mixed up while rebasing.
>     Fix that
> 
> v2: Fix patch version numbering. Incorrectly marked the first version as v0
>     Add interrupts and interrupt-names for ipq5332 instead of clubbing it with
>     qcom,x1e80100-dwc3
> ---
>  .../devicetree/bindings/usb/qcom,dwc3.yaml        | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: (subset) [PATCH v3 0/2] Fix ipq5332 usb interrupt trigger type

[Bjorn Andersson]

On Tue, 23 Jul 2024 15:31:49 +0530, Varadarajan Narayanan wrote:
> Trigger type is incorrectly specified as IRQ_TYPE_EDGE_BOTH
> instead of IRQ_TYPE_LEVEL_HIGH. This trigger type is not
> supported for SPIs and results in probe failure with -EINVAL.
> 
> Fix dt_binding_check/dtbs_check errors associated with usb's
> interrupts.
> 
> [...]

Applied, thanks!

[2/2] arm64: dts: qcom: ipq5332: Fix interrupt trigger type for usb
      commit: 60a76f7826b88ebf7697a56fdcd9596b23c2b616

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>