From: "Rob Herring (Arm)" <robh@kernel.org>
To: Tristram.Ha@microchip.com
Cc: "David S. Miller" <davem@davemloft.net>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Woojung Huh <woojung.huh@microchip.com>,
Tristram Ha <tristram.ha@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, Marek Vasut <marex@denx.de>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Vladimir Oltean <olteanv@gmail.com>,
UNGLinuxDriver@microchip.com,
Florian Fainelli <f.fainelli@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: dsa: microchip: Add KSZ8895/KSZ8864 switch support
Date: Thu, 08 Aug 2024 19:29:49 -0600 [thread overview]
Message-ID: <172316698916.2542023.14755989610157748245.robh@kernel.org> (raw)
In-Reply-To: <20240809004310.239242-2-Tristram.Ha@microchip.com>
On Thu, 08 Aug 2024 17:43:09 -0700, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
>
> KSZ8895/KSZ8864 is a switch family developed before KSZ8795 and after
> KSZ8863, so it shares some registers and functions in those switches.
> KSZ8895 has 5 ports and so is more similar to KSZ8795.
>
> KSZ8864 is a 4-port version of KSZ8895. The first port is removed
> while port 5 remains as a host port.
>
> Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
> ---
> Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml:24:26: [error] syntax error: found character '\t' that cannot start any token (syntax)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240809004310.239242-2-Tristram.Ha@microchip.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-08-09 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 0:43 [PATCH net-next v2 0/2] net: dsa: microchip: Add KSZ8895/KSZ8864 switch support Tristram.Ha
2024-08-09 0:43 ` [PATCH net-next v2 1/2] dt-bindings: " Tristram.Ha
2024-08-09 1:29 ` Rob Herring (Arm) [this message]
2024-08-09 0:43 ` [PATCH net-next v2 2/2] " Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172316698916.2542023.14755989610157748245.robh@kernel.org \
--to=robh@kernel.org \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).