From: "Rob Herring (Arm)" <robh@kernel.org>
To: Alexey Romanov <avromanov@salutedevices.com>
Cc: robh+dt@kernel.org, linux-crypto@vger.kernel.org,
clabbe@baylibre.com, neil.armstrong@linaro.org,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
vadim.fedorenko@linux.dev, linux-arm-kernel@lists.infradead.org,
kernel@salutedevices.com, krzysztof.kozlowski+dt@linaro.org,
davem@davemloft.net, conor+dt@kernel.org,
herbert@gondor.apana.org.au, devicetree@vger.kernel.org,
khilman@baylibre.com
Subject: Re: [PATCH v9 17/23] dt-bindings: crypto: meson: correct clk and remove second interrupt line
Date: Mon, 26 Aug 2024 08:50:47 -0500 [thread overview]
Message-ID: <172468024695.61392.174903956615697419.robh@kernel.org> (raw)
In-Reply-To: <20240820145623.3500864-18-avromanov@salutedevices.com>
On Tue, 20 Aug 2024 17:56:17 +0300, Alexey Romanov wrote:
> GXL and newer SoC's uses the DMA engine (not blkmv) for crypto HW.
> Crypto HW doesn't actually use the blkmv clk. At RTL level, crypto
> engine is hard-wired to a clk81 (CLKID_CLK81). Drop clock-names
> field from schema: name "blkmv" is invalid and "clk81" is confusing
> and sounds like something global.
>
> Also, GXL crypto IP isn't connected to the second interrupt line.
> This binding is useless, there are no users of this line.
> We must remove it from dt-bindings.
>
> Fixes: 7f7d115dfb51 ("dt-bindings: crypto: Add DT bindings documentation for amlogic-crypto")
> Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
> ---
> .../bindings/crypto/amlogic,gxl-crypto.yaml | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2024-08-26 13:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 14:56 [PATCH v9 00/23] Support more Amlogic SoC families in crypto driver Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 01/23] drivers: crypto: meson: don't hardcode IRQ count Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 02/23] drviers: crypto: meson: add platform data Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 03/23] drivers: crypto: meson: remove clock input Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 04/23] drivers: crypto: meson: add MMIO helpers Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 05/23] drivers: crypto: meson: move get_engine_number() Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 06/23] drivers: crypto: meson: drop status field from meson_flow Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 07/23] drivers: crypto: meson: move algs definition and cipher API to cipher.c Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 08/23] drivers: crypto: meson: cleanup defines Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 09/23] drivers: crypto: meson: process more than MAXDESCS descriptors Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 10/23] drivers: crypto: meson: avoid kzalloc in engine thread Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 11/23] drivers: crypto: meson: introduce hasher Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 12/23] drivers: crypto: meson: add support for AES-CTR Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 13/23] drivers: crypto: meson: use fallback for 192-bit keys Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 14/23] drivers: crypto: meson: add support for G12-series Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 15/23] drivers: crypto: meson: add support for AXG-series Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 16/23] drivers: crypto: meson: add support for A1-series Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 17/23] dt-bindings: crypto: meson: correct clk and remove second interrupt line Alexey Romanov
2024-08-26 13:50 ` Rob Herring (Arm) [this message]
2024-08-20 14:56 ` [PATCH v9 18/23] dt-bindings: crypto: meson: support new SoC's Alexey Romanov
2024-08-26 13:52 ` Rob Herring
2024-08-20 14:56 ` [PATCH v9 19/23] arch: arm64: dts: meson: gxl: correct crypto node definition Alexey Romanov
2024-08-26 13:50 ` Rob Herring
2024-08-20 14:56 ` [PATCH v9 20/23] arch: arm64: dts: meson: a1: add crypto node Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 21/23] arch: arm64: dts: meson: s4: " Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 22/23] arch: arm64: dts: meson: g12: " Alexey Romanov
2024-08-20 14:56 ` [PATCH v9 23/23] arch: arm64: dts: meson: axg: " Alexey Romanov
2024-08-21 8:28 ` Krzysztof Kozlowski
2024-08-20 15:19 ` [PATCH v9 00/23] Support more Amlogic SoC families in crypto driver neil.armstrong
2024-08-21 10:02 ` Alexey Romanov
2024-08-23 18:09 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172468024695.61392.174903956615697419.robh@kernel.org \
--to=robh@kernel.org \
--cc=avromanov@salutedevices.com \
--cc=clabbe@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jbrunet@baylibre.com \
--cc=kernel@salutedevices.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).