public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Tarang Raval <tarang.raval@siliconsignals.io>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
	 Conor Dooley <conor+dt@kernel.org>,
	shawnguo@kernel.org,  linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org,  Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	 imx@lists.linux.dev, linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v5] arm64: dts: imx8mm-emtop-baseboard: Add Peripherals Support
Date: Tue, 03 Sep 2024 09:26:44 -0500	[thread overview]
Message-ID: <172537334994.875077.18308965320836312656.robh@kernel.org> (raw)
In-Reply-To: <20240903091720.443091-1-tarang.raval@siliconsignals.io>


On Tue, 03 Sep 2024 14:47:20 +0530, Tarang Raval wrote:
> Add following peripherals support for the Emtop i.MX8M Mini Baseboard
> 
>         * Wi-Fi
>         * Audio
>         * SD card
>         * RTC
>         * CAN bus
>         * USB OTG
> 
> Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io>
> ---
> 
> Changes in v2:
> 
> 1. Updated the node name and pinctrl name.
> 2. Removed the 'regulators' container.
> 3. Removed a stray blank line.
> 4. Removed non-existent properties.
> 5. Removed unused node and pinctrl:
>    -modem-reset
>    -pinctrl_uart1
> 6. Defined the CAN transceiver reset GPIO separately.
> 
> Change in v3:
> 
> 1. Removed 'can-connector'.
> 2. Use USB connector instead of extcon_usb.
> 3. Changed id-gpio to id-gpios.
> 4. Use Level trigger IRQ in the CAN node.
> 5. Corrected the compatible property of RTC.
> 6. Added blank lines to separate the pinctrl groups.
> 
> Changes in v4:
> 
> 1. Sorted I2C device nodes by slave address.
> 2. Moved properties above the "status" property in the Wi-Fi node.
> 
> Change in v5:
> 
> 1. I mistakenly removed <pinctrl-canbus>; it has now been re-added.
> 2. Added Author name
> ---
>  .../dts/freescale/imx8mm-emtop-baseboard.dts  | 335 ++++++++++++++++++
>  1 file changed, 335 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y freescale/imx8mm-emtop-baseboard.dtb' for 20240903091720.443091-1-tarang.raval@siliconsignals.io:

arch/arm64/boot/dts/freescale/imx8mm-emtop-baseboard.dtb: /soc@0/bus@30800000/spba-bus@30800000/spi@30830000/can@0: failed to match any schema with compatible: ['microchip,mcp2515']






  reply	other threads:[~2024-09-03 14:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03  9:17 [PATCH v5] arm64: dts: imx8mm-emtop-baseboard: Add Peripherals Support Tarang Raval
2024-09-03 14:26 ` Rob Herring (Arm) [this message]
2024-09-03 14:28   ` Fabio Estevam
2024-09-03 14:31     ` Marc Kleine-Budde
2024-09-05  8:33       ` Tarang Raval
2024-09-05  8:44         ` Krzysztof Kozlowski
2024-10-09  7:03 ` Tarang Raval
2024-10-15  8:12 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172537334994.875077.18308965320836312656.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tarang.raval@siliconsignals.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox