From: "Rob Herring (Arm)" <robh@kernel.org>
To: Ciprian Costea <ciprianmarian.costea@oss.nxp.com>
Cc: Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Chester Lin <chester62515@gmail.com>,
linux-serial@vger.kernel.org,
Enric Balletbo <eballetb@redhat.com>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
devicetree@vger.kernel.org, NXP S32 Linux Team <s32@nxp.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: linflexuart: add clock definitions
Date: Mon, 14 Oct 2024 10:56:14 -0500 [thread overview]
Message-ID: <172892137480.1497237.16573929497529624657.robh@kernel.org> (raw)
In-Reply-To: <20241014144501.388050-2-ciprianmarian.costea@oss.nxp.com>
On Mon, 14 Oct 2024 17:45:00 +0300, Ciprian Costea wrote:
> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>
> Add clock definitions for NXP LINFlexD UART bindings
> and update the binding examples with S32G2 node.
>
> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
> ---
> .../bindings/serial/fsl,s32-linflexuart.yaml | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.example.dtb: serial@40053000: 'clocks' is a required property
from schema $id: http://devicetree.org/schemas/serial/fsl,s32-linflexuart.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.example.dtb: serial@40053000: 'clock-names' is a required property
from schema $id: http://devicetree.org/schemas/serial/fsl,s32-linflexuart.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241014144501.388050-2-ciprianmarian.costea@oss.nxp.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-10-14 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 14:44 [PATCH v2 0/2] add NXP LINFlexD UART clock support for S32G2/S32G3 Ciprian Costea
2024-10-14 14:45 ` [PATCH v2 1/2] dt-bindings: linflexuart: add clock definitions Ciprian Costea
2024-10-14 15:56 ` Rob Herring (Arm) [this message]
2024-10-14 14:45 ` [PATCH v2 2/2] serial: fsl_linflexuart: add clock support Ciprian Costea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172892137480.1497237.16573929497529624657.robh@kernel.org \
--to=robh@kernel.org \
--cc=aruizrui@redhat.com \
--cc=chester62515@gmail.com \
--cc=ciprianmarian.costea@oss.nxp.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).