[PATCH] regulator: rename regulator-uv-survival-time-ms according to DT binding

[PATCH] regulator: rename regulator-uv-survival-time-ms according to DT binding

[Ahmad Fatoum]

The regulator bindings don't document regulator-uv-survival-time-ms, but
the more descriptive regulator-uv-less-critical-window-ms instead.

Looking back at v3[1] and v4[2] of the series adding the support,
the property was indeed renamed between these patch series, but
unfortunately the rename only made it into the DT bindings with the
driver code still using the old name.

Let's therefore rename the property in the driver code to follow suit.
This will break backwards compatibility, but there are no upstream
device trees using the property and we never documented the old name
of the property anyway. ¯\_(ツ)_/¯"

[1]: https://lore.kernel.org/all/20231025084614.3092295-7-o.rempel@pengutronix.de/
[2]: https://lore.kernel.org/all/20231026144824.4065145-5-o.rempel@pengutronix.de/

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/regulator/of_regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index 3d85762beda636479f3b3b808602a0be221c0c77..e5b4b93c07e3f5e36122a804d3022eba0b2d6ad9 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -175,7 +175,7 @@ static int of_get_regulation_constraints(struct device *dev,
 	if (!ret)
 		constraints->enable_time = pval;
 
-	ret = of_property_read_u32(np, "regulator-uv-survival-time-ms", &pval);
+	ret = of_property_read_u32(np, "regulator-uv-less-critical-window-ms", &pval);
 	if (!ret)
 		constraints->uv_less_critical_window_ms = pval;
 	else

---
base-commit: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
change-id: 20241218-regulator-uv-survival-time-ms-rename-79e43cb4a181

Best regards,
-- 
Ahmad Fatoum <a.fatoum@pengutronix.de>

Re: [PATCH] regulator: rename regulator-uv-survival-time-ms according to DT binding

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

On Wed, Dec 18, 2024 at 08:54:53PM +0100, Ahmad Fatoum wrote:

> Let's therefore rename the property in the driver code to follow suit.
> This will break backwards compatibility, but there are no upstream
> device trees using the property and we never documented the old name
> of the property anyway. ¯\_(ツ)_/¯"

We should clearly have the new name, if someone needs the old name we
can always re-add it as a fallback.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] regulator: rename regulator-uv-survival-time-ms according to DT binding

[Mark Brown]

On Wed, 18 Dec 2024 20:54:53 +0100, Ahmad Fatoum wrote:
> The regulator bindings don't document regulator-uv-survival-time-ms, but
> the more descriptive regulator-uv-less-critical-window-ms instead.
> 
> Looking back at v3[1] and v4[2] of the series adding the support,
> the property was indeed renamed between these patch series, but
> unfortunately the rename only made it into the DT bindings with the
> driver code still using the old name.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: rename regulator-uv-survival-time-ms according to DT binding
      commit: 13221496065fa12fac4f8a8e725444679ffddb78

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark