From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH 1/2] Documentation: devicetree: Add i2c binding for mediatek MT2701 Soc Platform Date: Tue, 24 Jan 2017 16:03:16 +0100 Message-ID: <1735f06b-4e3c-bc22-eb9c-3e61e714d0b9@gmail.com> References: <1484719658-11901-1-git-send-email-jun.gao@mediatek.com> <1484719658-11901-2-git-send-email-jun.gao@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1484719658-11901-2-git-send-email-jun.gao@mediatek.com> Sender: linux-i2c-owner@vger.kernel.org To: Jun Gao , Wolfram Sang Cc: srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, erin.lo@mediatek.com List-Id: devicetree@vger.kernel.org On 01/18/2017 07:07 AM, Jun Gao wrote: > From: Jun Gao > > This add i2c DT binding to i2c-mt6577.txt for MT2701. > > Signed-off-by: Jun Gao > --- > .../devicetree/bindings/i2c/i2c-mt6577.txt | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt > b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt > index 0ce6fa3..ef22ecf 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with > I2C devices. > > Required properties: > - compatible: value should be either of the following. > - (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c. > - (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c. > - (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c. > - (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c. > - (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c. > + "mediatek,mt2701-i2c", for i2c compatible with mt2701 i2c. > + "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c. > + "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c. > + "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c. > + "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c. > + "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c. > - reg: physical base address of the controller and dma base, length of > memory > mapped region. > - interrupts: interrupt number to the cpu. > Actually what you need for mt2701 is what you put into the dts file: compatible = "mediatek,mt2701-i2c", "mediatek,mt6577-i2c"; "mediatek,mt2701-i2c" alone is not supported in the driver. While at it would you mind to fix the bindings description for the other SoCs as well? Thanks, Matthias