From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] ARM: dts: rockchip: Adding LEDs handling via leds-gpio for the Radxa Rock2 Square Date: Wed, 30 Dec 2015 17:43:05 +0100 Message-ID: <1737278.m4cbh3zLlq@diego> References: <1451474219-1313-1-git-send-email-romain.perier@gmail.com> <3020768.zersTrE99c@diego> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Romain Perier Cc: Sjoerd Simons , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "open list:ARM/Rockchip SoC..." , devicetree List-Id: devicetree@vger.kernel.org Am Mittwoch, 30. Dezember 2015, 17:07:54 schrieb Romain Perier: > Hi all, >=20 > I agree with Sjoerd, that's more useful to keep these LEDs in sync > with the default vendor behaviour than put their default state to off > and ask the user to manipulate them explicitly... in the worst case, > he can still change the default state from sysfs... >=20 > 2015-12-30 16:53 GMT+01:00 Heiko St=FCbner : > >> > even a oneliner is generally preferred, compared to no commit me= ssage > >> > at all > >> > ;-) >=20 > Well, lack of inspiration :P > No, just kidding, I agree. >=20 > >> > > Signed-off-by: Romain Perier > >> > > --- > >> > >=20 > >> > > arch/arm/boot/dts/rk3288-rock2-square.dts | 17 ++++++++++++++= +++ > >> > > 1 file changed, 17 insertions(+) > >> > >=20 > >> > > diff --git a/arch/arm/boot/dts/rk3288-rock2-square.dts > >> > > b/arch/arm/boot/dts/rk3288-rock2-square.dts index c5453a0..a33= 020f > >> > > 100644 > >> > > --- a/arch/arm/boot/dts/rk3288-rock2-square.dts > >> > > +++ b/arch/arm/boot/dts/rk3288-rock2-square.dts > >> > > @@ -56,6 +56,23 @@ > >> > >=20 > >> > > pinctrl-0 =3D <&ir_int>; > >> > > =20 > >> > > }; > >> > >=20 > >> > > + gpio-leds { > >> > > + compatible =3D "gpio-leds"; > >> > > + > >> > > + heartbeat { > >> > > + gpios =3D <&gpio7 15 GPIO_ACTIVE_LOW>; > >> > > + label =3D "rock2:green:heartbeat"; > >> > > + linux,default-trigger =3D "heartbeat"; > >> > > + }; > >> > > + > >> > > + mmc { > >> > > + gpios =3D <&gpio0 11 GPIO_ACTIVE_LOW>; > >> > > + label =3D "rock2:blue:mmc"; > >> > > + linux,default-trigger =3D "mmc0"; > >> > > + }; > >> >=20 > >> > the rock2 core schematics seem to not list these leds at all > >> > (especially when > >> > looking at the gpio-side). But looking at the schematics my gues= s > >> > would be > >> > led_state1 and led_state2, so the naming should reflect that > >> > (rock2:green:state1 ...). >=20 > I used the schematic and the vendor devicetree to retrieve these > informations. > > Anybody opposed to me adding the following commit message? > >=20 > > ---- > > Describe the two user-controllable LEDs on Rock2-square boards. > > The default-triggers mimic the behaviour of the vendor-kernel to > > keep functionalities in sync. > > ---- >=20 > +1 > Please do. >=20 > Do you want a v2 patch ? (the label of these leds is wrong) yep, bringing everything together makes sense :-) Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html