From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99BB1145A16; Thu, 23 Jan 2025 11:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737631363; cv=none; b=Ex0a6HeSqVMGM1lFu+XF175vag8cQwlkgkjwwVqL8eIi7AdaP5b0YH5dEczn5DUsQ+MdZgM8qE7bN9Li9Z4wH4RP/sRdFahggMbbjJSCodDdloXQEzMkbkSjWdJvwfJa2xKpto2rY/h0Ydo4Tr9pC2c+FUN7IiTzblOX17dnrfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737631363; c=relaxed/simple; bh=dOPumK8qpk9/lF2H2ETAfWwPgfWjceIap9jfDJzhbCQ=; h=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References: Message-Id:Subject; b=AoTrFF5RPxP+y3H8SIxAdZIcUmtP8+r0MzwrcXLsl5S2OB5tzzg5aeWrbdfobvC/yHt6AD37mEOly1ja4BAM5BaUWNbvEUUC5Cmt4SCty/AHW+MBAkQa//k9galFqcFTuk68EKXV6yAK4nJN9UrI7TLNOj/6v2qwvLcNxwT6I/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U6jJOoa9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U6jJOoa9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCD1DC4CED3; Thu, 23 Jan 2025 11:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737631363; bh=dOPumK8qpk9/lF2H2ETAfWwPgfWjceIap9jfDJzhbCQ=; h=Date:From:Cc:To:In-Reply-To:References:Subject:From; b=U6jJOoa9E7/CT2C3/91caq1JtSj0tQh/jMzWt6DTk8r8w8PtvqJ+Gd+pl5fQPOpHo rBU7c3ISLWVl+8dy74YjwInGSqHG9l0D3pLGU44zcgPyDPyZVa8nuZE/VgYcJs+Ucz hnTpXJwl+ahiaWzHd6O+xt7yeG/oaobCNUZ1W9RKH3iM+Gtsn6nMIV5bzXZlgoo3Ga QsDHUHTm34pMdIhQKCrbrv5wsEc1oN+o1bYKYVZmjYgaLouHo+DY1PHMepe9BDvVVF ai40tdrnqUb61zhmmFw4CgVNn++RSKtRsr7j8e+hKxCoWw7DyBJY2IboaODdIqlHfo YHxBbgw1FhlBw== Date: Thu, 23 Jan 2025 05:22:41 -0600 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: devicetree@vger.kernel.org, kever.yang@rock-chips.com, l.stach@pengutronix.de, linux-phy@lists.infradead.org, vkoul@kernel.org, linux-kernel@vger.kernel.org, cristian.ciocaltea@collabora.com, hjc@rock-chips.com, sebastian.reichel@collabora.com, dmitry.baryshkov@linaro.org, rfoss@kernel.org, krzk+dt@kernel.org, heiko@sntech.de, andy.yan@rock-chips.com, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, algea.cao@rock-chips.com, linux-rockchip@lists.infradead.org, conor+dt@kernel.org To: Damon Ding In-Reply-To: <20250123100747.1841357-10-damon.ding@rock-chips.com> References: <20250123100747.1841357-1-damon.ding@rock-chips.com> <20250123100747.1841357-10-damon.ding@rock-chips.com> Message-Id: <173763136187.3345079.11905359473404124812.robh@kernel.org> Subject: Re: [PATCH v6 09/14] dt-bindings: display: rockchip: analogix-dp: Add support for RK3588 On Thu, 23 Jan 2025 18:07:42 +0800, Damon Ding wrote: > Compared with RK3288/RK3399, the HBR2 link rate support is the main > improvement of RK3588 eDP TX controller, and there are also two > independent eDP display interfaces on RK3588 Soc. > > The newly added 'apb' reset is to ensure the APB bus of eDP controller > works well on the RK3588 SoC. > > Signed-off-by: Damon Ding > > --- > > Changes in v2: > - Add the main defferences of the RK3588 eDP and the previous versions > in commit message > > Changes in v3: > - Expand the property clock-names, resets and reset-names > > Changes in v4: > - Remove 'spdif' clock which added in v3 > - Add the comment of newly added 'apb' reset in commit message > > Changes in v5: > - Put the differences between RK3288/RK3399 and RK3588 into 'allOf' > > Changes in v6: > - Keep the widest constraints and add only RK3588 related constraints > into 'allOf' > --- > .../rockchip/rockchip,analogix-dp.yaml | 22 ++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml: properties:reset-names: 'const' should not be valid under {'enum': ['const', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']} hint: Scalar and array keywords cannot be mixed from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml: properties:reset-names: 'const' should not be valid under {'enum': ['const', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']} hint: Scalar and array keywords cannot be mixed from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250123100747.1841357-10-damon.ding@rock-chips.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.