From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA218C433E6 for ; Mon, 15 Mar 2021 16:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F53964F36 for ; Mon, 15 Mar 2021 16:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232437AbhCOQxW convert rfc822-to-8bit (ORCPT ); Mon, 15 Mar 2021 12:53:22 -0400 Received: from gloria.sntech.de ([185.11.138.130]:35506 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233468AbhCOQxG (ORCPT ); Mon, 15 Mar 2021 12:53:06 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLqSI-0001JB-1E; Mon, 15 Mar 2021 17:52:34 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Robin Murphy , Geert Uytterhoeven Cc: CN_SZTL , Rob Herring , Jagan Teki , Chen-Yu Tsai , Geert Uytterhoeven , David Bauer , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= , Johan Jonker , Michael Trimarchi , Marty Jones , Jensen Huang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , kernel test robot Subject: Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S Date: Mon, 15 Mar 2021 17:52:32 +0100 Message-ID: <17376355.sWSEgdgrri@diego> In-Reply-To: References: <20210313032515.12590-1-cnsztl@gmail.com> <67b314e7-92b9-8025-1a41-9b7da6ff2249@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Montag, 15. März 2021, 17:38:37 CET schrieb Geert Uytterhoeven: > Hi Robin, > > On Mon, Mar 15, 2021 at 5:32 PM Robin Murphy wrote: > > On 2021-03-13 13:22, CN_SZTL wrote: > > > Robin Murphy 于2021年3月13日周六 下午7:55写道： > > >> > > >> On 2021-03-13 03:25, Tianling Shen wrote: > > >>> + gpio-leds { > > >>> + compatible = "gpio-leds"; > > >>> + pinctrl-0 = <&lan_led_pin>, <&sys_led_pin>, <&wan_led_pin>; > > >>> + pinctrl-names = "default"; > > >>> + > > >>> + lan_led: led-0 { > > >>> + gpios = <&gpio1 RK_PA1 GPIO_ACTIVE_HIGH>; > > >>> + label = "nanopi-r4s:green:lan"; > > >>> + }; > > >>> + > > >>> + sys_led: led-1 { > > >>> + gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>; > > >>> + label = "nanopi-r4s:red:sys"; > > >>> + default-state = "on"; > > >>> + }; > > >>> + > > >>> + wan_led: led-2 { > > >>> + gpios = <&gpio1 RK_PA0 GPIO_ACTIVE_HIGH>; > > >>> + label = "nanopi-r4s:green:wan"; > > >>> + }; > > > > Nit: (apologies for overlooking it before) there isn't an obvious > > definitive order for the LEDs, but the order here is certainly not > > consistent with anything. The most logical would probably be sys, wan, > > Looks like alphabetical sort order to me ;-) yep ... led-0, led-1, led-2 looks pretty sorted ;-) Generally I'd prefer sorting by node-names ... especially as the phandle is sort of optional for most things - and they sometimes come and go in dt-files. Heiko