Re: [PATCH v11 09/24] drm/rockchip: dw_hdmi: add regulator support

[Diederik de Haas <didi.debian@cknow.org>]

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

On Thursday, 4 July 2024 12:00:43 CEST Heiko Stübner wrote:
> > Is it possible to probe for those avdd_0v9 and avdd_1v8 regulators only on
> > devices that should have them?
> > 
> > On a Rock64 (rk3328), but probably for all VOP1 devices, they're not
> > present and that results in the following warnings:
> > dwhdmi-rockchip ff3c0000.hdmi: supply avdd-0v9 not found, using dummy
> > regulator dwhdmi-rockchip ff3c0000.hdmi: supply avdd-1v8 not found, using
> > dummy regulator
> counter-argument, why not define them in the dts?
> I.e. looking at the rock64 schematics, you want the dvideo_avdd_1v8 (from
> LDO1) and dvideo_avdd_1v0 (from LDO3) if I'm not mistaken. Why this stuff
> is called dvideo and not hdmi in there I have no clue ;-)

That appears to be a valid counter-argument ...

On donderdag 4 juli 2024 12:28:53 CEST Alex Bee wrote:
> Those regulators exist for _all_ RK SoCs that use dw-hdmi controller, as it
> has to be supplied in same why (as it is always the same controller). In
> particular case of rock64[0] its:
> 
> DVIDEO_AVDD_1V8P6 -> VCC_18
> DVIDEO_AVDD_1V0M6 -> VDD_10
> 
> So: Just fix the device tree and your warnings are gone :)
> 
> [0] https://files.pine64.org/doc/rock64/ROCK64_Schematic_v2.0_20171019.pdf

... confirmed by Alex Bee.

I do wonder about 0.9V vs 1.0V, but I'll bug someone else about that ;-)

Cheers,
  Diederik

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]