* [PATCH] arm64: dts: rockchip: Assign mic irq to correct device for Gru
@ 2017-08-16 9:24 Jeffy Chen
2017-08-18 23:17 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Jeffy Chen @ 2017-08-16 9:24 UTC (permalink / raw)
To: linux-kernel, hychao
Cc: briannorris, dianders, Jeffy Chen, Matthias Kaehlcke,
Heiko Stuebner, devicetree, Klaus Goger, linux-rockchip,
Rob Herring, linux-arm-kernel, Will Deacon, Mark Rutland,
Catalin Marinas
Currently we are assigning mic irq to rt5514 i2c driver, which is wrong.
Assign it to rt5514 spi driver instead.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
index d48e98b62d09..d7723a77ae03 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
@@ -612,12 +612,8 @@ ap_i2c_mic: &i2c1 {
headsetcodec: rt5514@57 {
compatible = "realtek,rt5514";
reg = <0x57>;
- interrupt-parent = <&gpio1>;
- interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
- pinctrl-names = "default";
- pinctrl-0 = <&mic_int>;
+
realtek,dmic-init-delay = <20>;
- wakeup-source;
};
};
@@ -826,9 +822,13 @@ ap_i2c_audio: &i2c8 {
wacky_spi_audio: spi2@0 {
compatible = "realtek,rt5514";
reg = <0>;
-
+ interrupt-parent = <&gpio1>;
+ interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&mic_int>;
/* May run faster once verified. */
spi-max-frequency = <10000000>;
+ wakeup-source;
};
};
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Assign mic irq to correct device for Gru
2017-08-16 9:24 [PATCH] arm64: dts: rockchip: Assign mic irq to correct device for Gru Jeffy Chen
@ 2017-08-18 23:17 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2017-08-18 23:17 UTC (permalink / raw)
To: Jeffy Chen
Cc: linux-kernel, hychao, briannorris, dianders, Matthias Kaehlcke,
devicetree, Klaus Goger, linux-rockchip, Rob Herring,
linux-arm-kernel, Will Deacon, Mark Rutland, Catalin Marinas
Am Mittwoch, 16. August 2017, 17:24:32 CEST schrieb Jeffy Chen:
> Currently we are assigning mic irq to rt5514 i2c driver, which is wrong.
> Assign it to rt5514 spi driver instead.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
applied for 4.14
Thanks
Heiko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-18 23:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-16 9:24 [PATCH] arm64: dts: rockchip: Assign mic irq to correct device for Gru Jeffy Chen
2017-08-18 23:17 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).