From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stefan Hansson <newbie13xd@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
phone-devel@vger.kernel.org
Cc: Anton Bambura <jenneron@protonmail.com>,
Gregari Ivanov <llamashere@posteo.de>
Subject: Re: [PATCH] arm64: dts: qcom: add device tree for LG G7 and LG V35
Date: Fri, 3 Jun 2022 11:56:00 +0200 [thread overview]
Message-ID: <173ad8d6-44b3-444b-c72d-f35e83d7ed1a@linaro.org> (raw)
In-Reply-To: <6927df15-54d1-bf1e-0e34-9524e79e3f0a@gmail.com>
On 03/06/2022 11:47, Stefan Hansson wrote:
>>> + gpio-keys {
>>> + compatible = "gpio-keys";
>>> +
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&vol_up_pin_a>;
>>> +
>>> + label = "GPIO Buttons";
>>
>> Is "label" really a property of gpio-keys node?
>>
>
> I tested these dts:es with dtbs_check and I do not see any errors
> regarding labels. If you prefer me to delete this I can do that. I
> understand it is rather weird to have this here if it's not in the
> schema. I am rather new to writing device trees, so I think you are
> better off making the call here.
Thanks for reporting. Indeed current DT schema won't detect this. Anyway
it seems gpio-keys driver already uses it and since it appeared in DTS,
maybe better to document it. I'll work on this, so feel free to keep the
property.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-06-03 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 12:07 [PATCH] arm64: dts: qcom: add device tree for LG G7 and LG V35 Stefan Hansson
2022-06-02 12:19 ` Krzysztof Kozlowski
2022-06-03 9:47 ` Stefan Hansson
2022-06-03 9:56 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173ad8d6-44b3-444b-c72d-f35e83d7ed1a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jenneron@protonmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=llamashere@posteo.de \
--cc=newbie13xd@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).