From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: devicetree@vger.kernel.org, bcousson@baylibre.com,
khilman@baylibre.com, dri-devel@lists.freedesktop.org,
bgolaszewski@baylibre.com, tomi.valkeinen@ti.com
Subject: Re: [PATCH 2/3] drm/bridge: Add ti-ftp410 HDMI transmitter driver
Date: Mon, 14 Nov 2016 13:10:52 +0200 [thread overview]
Message-ID: <1740464.TP0bE1PYbC@avalon> (raw)
In-Reply-To: <d035c76e-ca7f-0503-87da-7e93783d1cd0@ti.com>
Hi Jyri,
On Monday 14 Nov 2016 10:49:43 Jyri Sarha wrote:
> On 11/03/16 19:46, Laurent Pinchart wrote:
> >> +Required properties:
> >> > + - compatible: "ti,tfp410"
> >
> > The device is an I2C slave, it should have a reg property. Given that the
> > chip can be used without being controlled through I2C, the reg property
> > should be optional. You should document this clearly, and explain how the
> > DT node can be instantiated as a child of an I2C controller when the I2C
> > interface is used, or in other parts of the device tree otherwise.
>
> Shouldn't I have two different compatible strings if want to make both
> platform driver probe and i2c client probe to work?
I don't think so, it's still the same chip.
> Or can it be done with single compatible string? Would you know of an
> example of such a driver?
You will need to register both a i2c_driver and a platform_driver in the
tfp410 driver. Both will advertise the same compatible string. As you'll have
two probe functions, it should be easy to handle the differences between the
two situations there, with common code shared in common functions. A quick
grep points to at least drivers/power/bq27x00_battery.c as an example (albeit
without DT support).
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-11-14 11:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 16:32 [PATCH 0/3] drm/tilcdc: Add bridge support and sync-lost flood recovery Jyri Sarha
2016-11-02 16:32 ` [PATCH 1/3] drm/tilcdc: Recover from sync lost error flood by resetting the LCDC Jyri Sarha
2016-11-02 16:32 ` [PATCH 2/3] drm/bridge: Add ti-ftp410 HDMI transmitter driver Jyri Sarha
2016-11-03 10:24 ` Tomi Valkeinen
2016-11-03 17:46 ` Laurent Pinchart
2016-11-10 9:16 ` Jyri Sarha
2016-11-10 12:15 ` Laurent Pinchart
2016-11-10 12:16 ` Tomi Valkeinen
2016-11-14 8:49 ` Jyri Sarha
2016-11-14 11:10 ` Laurent Pinchart [this message]
2016-11-14 11:16 ` Tomi Valkeinen
[not found] ` <ac8e0f72-fac2-45e5-0004-d6028ddeb221-l0cyMroinI0@public.gmane.org>
2016-11-14 11:22 ` Laurent Pinchart
2016-11-02 16:32 ` [PATCH 3/3] drm/tilcdc: Add drm bridge support for attaching drm bridge drivers Jyri Sarha
2016-11-03 17:50 ` Laurent Pinchart
[not found] ` <463d18493ac508708ed764e71d11c2b89662544c.1478103726.git.jsarha-l0cyMroinI0@public.gmane.org>
2016-11-10 0:50 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1740464.TP0bE1PYbC@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=bcousson@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=khilman@baylibre.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).