From: "Rob Herring (Arm)" <robh@kernel.org>
To: Sergio Perez <sergio@pereznus.es>
Cc: jic23@kernel.org, tduszyns@gmail.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] [v2] iio: light: bh1750: Add hardware reset support via GPIO
Date: Mon, 17 Mar 2025 14:29:33 -0500 [thread overview]
Message-ID: <174223977381.441039.14907108652302034941.robh@kernel.org> (raw)
In-Reply-To: <20250317175621.593-1-sergio@pereznus.es>
On Mon, 17 Mar 2025 18:56:21 +0100, Sergio Perez wrote:
> Some BH1750 sensors require a hardware reset before they can be
> detected on the I2C bus. This patch adds support for an optional
> reset GPIO that can be specified in the device tree.
>
> The reset sequence pulls the GPIO low and then high before
> initializing the sensor, which enables proper detection with
> tools like i2cdetect.
>
> Signed-off-by: Sergio Perez <sergio@pereznus.es>
> ---
> .../devicetree/bindings/iio/light/bh1750.yaml | 7 +++++-
> drivers/iio/light/bh1750.c | 24 ++++++++++++++++++-
> 2 files changed, 29 insertions(+), 2 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/iio/light/bh1750.yaml:50:4: [error] no new line character at the end of file (new-line-at-end-of-file)
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/iio/light/bh1750.example.dts:25.38-39 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/iio/light/bh1750.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1522: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250317175621.593-1-sergio@pereznus.es
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-03-17 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 17:56 [PATCH] [v2] iio: light: bh1750: Add hardware reset support via GPIO Sergio Perez
2025-03-17 19:29 ` Rob Herring (Arm) [this message]
2025-03-18 7:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174223977381.441039.14907108652302034941.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=sergio@pereznus.es \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox