Re: [PATCH 3/5] arm64: dts: qcom: r0q: enable max77705 PMIC

["Eric Gonçalves" <ghatto404@gmail.com>]

On October 8, 2025 5:34:00 AM GMT-03:00, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>On 9/26/25 4:19 AM, Eric Gonçalves wrote:
>> 
>> 
>> On September 25, 2025 10:06:53 AM GMT-03:00, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>>> On 9/20/25 3:46 AM, Eric Gonçalves wrote:
>>>> The Samsung Galaxy S22 uses max77705 as its charger, fuelgauge and haptic
>>>> PMIC, enable the fuelgauge and charger for now.
>>>>
>>>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>>>> ---
>>>
>>> [...]
>>>
>>>> +&i2c5 {
>>>> +	status = "okay";
>>>> +
>>>> +	max77705_charger: charger@69 {
>>>> +	    compatible = "maxim,max77705-charger";
>>>> +	    reg = <0x69>;
>>>
>>> Please use tabs consistently
>> Sure
>>>
>>>> +	    monitored-battery = <&battery>;
>>>> +	    interrupt-parent = <&tlmm>;
>>>> +	    interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
>>>
>>> interrupts-extended = <&tlmm 5 IRQ...>, here and below
>> why extended?
>>>
>>>> +	};
>>>> +
>>>> +	fuel-gauge@36 {
>>>> +		reg = <0x36>;
>>>
>>> sorting by unit address is welcome
>> Sure
>>>
>>>> +		compatible = "maxim,max77705-battery";
>>>> +		power-supplies = <&max77705_charger>;
>>>> +		interrupt-parent = <&tlmm>;
>>>> +		interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
>>>> +	};
>>>
>>> These nodes should be children of "maxim,max77705"
>>> (see drivers/mfd/max77705.c)
>> What do you mean by this? I looked at the driver, 
>> should I add the pmic@66 node and put
>> the units inside of it? Because starqltechn doesn't do that and
>> places them outside. Also, by adding the
>> pmic@66
>> node it expects to have led/haptics nodes as well.
>
>Well, the chip comes as a single package, so this only makes sense
>and the bindings (mfd/maxim,max77705.yaml) corroborate that.
>
>Just looking at the YAML, you should be able to omit the LED part
>if it's not connected anywhere
Well, looking at power/supply/maxim,max77705.yaml shows
that this is how it's meant to be defined, (outside the
maxim,max77705 node), no?
>
>Konrad