devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: amlogic: gxlx-s905l-p271: add saradc compatible
@ 2025-03-30 14:32 Christian Hewitt
  2025-03-30 14:58 ` Martin Blumenstingl
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Christian Hewitt @ 2025-03-30 14:32 UTC (permalink / raw)
  To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-arm-kernel, linux-amlogic, linux-kernel
  Cc: Christian Hewitt

Add the saradac node using the meson-gxlx-saradc compatible to ensure
MPLL clocks are poked and audio output is enabled on the p271 (S905L)
board.

Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
The meson-gxlx-saradc compatible is now merged via the IIO tree, see [0].                                   

[0] https://patchwork.kernel.org/project/linux-amlogic/cover/20250330101922.1942169-1-martin.blumenstingl@googlemail.com/

 arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts b/arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts
index 942df754a0ed..1221f4545130 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts
@@ -38,6 +38,10 @@ mali: gpu@c0000 {
 	};
 };
 
+&saradc {
+	compatible = "amlogic,meson-gxlx-saradc", "amlogic,meson-saradc";
+};
+
 &usb {
 	dr_mode = "host";
 };
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: amlogic: gxlx-s905l-p271: add saradc compatible
  2025-03-30 14:32 [PATCH] arm64: dts: amlogic: gxlx-s905l-p271: add saradc compatible Christian Hewitt
@ 2025-03-30 14:58 ` Martin Blumenstingl
  2025-03-31  7:01 ` Neil Armstrong
  2025-03-31 13:32 ` Rob Herring (Arm)
  2 siblings, 0 replies; 4+ messages in thread
From: Martin Blumenstingl @ 2025-03-30 14:58 UTC (permalink / raw)
  To: Christian Hewitt
  Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree, linux-arm-kernel,
	linux-amlogic, linux-kernel

On Sun, Mar 30, 2025 at 4:32 PM Christian Hewitt
<christianshewitt@gmail.com> wrote:
>
> Add the saradac node using the meson-gxlx-saradc compatible to ensure
> MPLL clocks are poked and audio output is enabled on the p271 (S905L)
> board.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: amlogic: gxlx-s905l-p271: add saradc compatible
  2025-03-30 14:32 [PATCH] arm64: dts: amlogic: gxlx-s905l-p271: add saradc compatible Christian Hewitt
  2025-03-30 14:58 ` Martin Blumenstingl
@ 2025-03-31  7:01 ` Neil Armstrong
  2025-03-31 13:32 ` Rob Herring (Arm)
  2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2025-03-31  7:01 UTC (permalink / raw)
  To: Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree, linux-arm-kernel,
	linux-amlogic, linux-kernel, Christian Hewitt

Hi,

On Sun, 30 Mar 2025 14:32:54 +0000, Christian Hewitt wrote:
> Add the saradac node using the meson-gxlx-saradc compatible to ensure
> MPLL clocks are poked and audio output is enabled on the p271 (S905L)
> board.
> 
> 

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.16/arm64-dt)

[1/1] arm64: dts: amlogic: gxlx-s905l-p271: add saradc compatible
      https://git.kernel.org/amlogic/c/cb99bb034123ef8b8dd533fc4c42164b049515a2

These changes has been applied on the intermediate git tree [1].

The v6.16/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: amlogic: gxlx-s905l-p271: add saradc compatible
  2025-03-30 14:32 [PATCH] arm64: dts: amlogic: gxlx-s905l-p271: add saradc compatible Christian Hewitt
  2025-03-30 14:58 ` Martin Blumenstingl
  2025-03-31  7:01 ` Neil Armstrong
@ 2025-03-31 13:32 ` Rob Herring (Arm)
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-03-31 13:32 UTC (permalink / raw)
  To: Christian Hewitt
  Cc: Neil Armstrong, Krzysztof Kozlowski, Martin Blumenstingl,
	linux-amlogic, linux-arm-kernel, linux-kernel, Conor Dooley,
	devicetree, Jerome Brunet, Kevin Hilman


On Sun, 30 Mar 2025 14:32:54 +0000, Christian Hewitt wrote:
> Add the saradac node using the meson-gxlx-saradc compatible to ensure
> MPLL clocks are poked and audio output is enabled on the p271 (S905L)
> board.
> 
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> The meson-gxlx-saradc compatible is now merged via the IIO tree, see [0].
> 
> [0] https://patchwork.kernel.org/project/linux-amlogic/cover/20250330101922.1942169-1-martin.blumenstingl@googlemail.com/
> 
>  arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20250328 (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for 20250330143254.3159519-1-christianshewitt@gmail.com:

arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dtb: adc@8680: compatible: 'oneOf' conditional failed, one must be fixed:
	['amlogic,meson-gxlx-saradc', 'amlogic,meson-saradc'] is too long
	'amlogic,meson-saradc' was expected
	'amlogic,meson-gxlx-saradc' is not one of ['amlogic,meson8-saradc', 'amlogic,meson8b-saradc', 'amlogic,meson8m2-saradc', 'amlogic,meson-gxbb-saradc', 'amlogic,meson-gxl-saradc', 'amlogic,meson-gxm-saradc', 'amlogic,meson-axg-saradc', 'amlogic,meson-g12a-saradc']
	from schema $id: http://devicetree.org/schemas/iio/adc/amlogic,meson-saradc.yaml#
arch/arm64/boot/dts/amlogic/meson-gxlx-s905l-p271.dtb: /soc/bus@c1100000/adc@8680: failed to match any schema with compatible: ['amlogic,meson-gxlx-saradc', 'amlogic,meson-saradc']






^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-03-31 13:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-30 14:32 [PATCH] arm64: dts: amlogic: gxlx-s905l-p271: add saradc compatible Christian Hewitt
2025-03-30 14:58 ` Martin Blumenstingl
2025-03-31  7:01 ` Neil Armstrong
2025-03-31 13:32 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).