Devicetree
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Ante Knezic <ante.knezic@helmholz.de>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, lee@kernel.org,
	 pavel@kernel.org, linux-doc@vger.kernel.org,
	linux-leds@vger.kernel.org,  knezic@helmholz.com, corbet@lwn.net,
	linux-kernel@vger.kernel.org,  krzk+dt@kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: leds: add binding for WL-ICLED
Date: Mon, 14 Apr 2025 10:27:25 -0500	[thread overview]
Message-ID: <174464444574.455759.7081664205185002557.robh@kernel.org> (raw)
In-Reply-To: <35c7f697070b3939727f1115d3a279e280f72cd6.1744636666.git.knezic@helmholz.com>


On Mon, 14 Apr 2025 15:28:50 +0200, Ante Knezic wrote:
> From: Ante Knezic <knezic@helmholz.com>
> 
> WL-ICLED is a RGB LED with integrated IC from Wurth Elektronik.
> Individual color brightness can be controlled via SPI protocol.
> 
> Signed-off-by: Ante Knezic <knezic@helmholz.com>
> ---
>  .../bindings/leds/leds-wl-icled.yaml          | 88 +++++++++++++++++++
>  1 file changed, 88 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-wl-icled.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-wl-icled.example.dtb: icled@1 (we,131x000): 'cs-gpios', 'reg' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/leds/leds-wl-icled.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/35c7f697070b3939727f1115d3a279e280f72cd6.1744636666.git.knezic@helmholz.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-04-14 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 13:28 [PATCH 0/3] Add support for WL-ICLEDs from Wurth Elektronik Ante Knezic
2025-04-14 13:28 ` [PATCH 1/3] Documentation: leds: Add docs for Wurth Elektronik WL-ICLED Ante Knezic
2025-04-15  2:27   ` Bagas Sanjaya
2025-04-14 13:28 ` [PATCH 2/3] dt-bindings: leds: add binding for WL-ICLED Ante Knezic
2025-04-14 15:27   ` Rob Herring (Arm) [this message]
2025-04-15  7:55   ` Krzysztof Kozlowski
2025-04-16  9:06     ` Ante Knezic
2025-04-16 10:21       ` Krzysztof Kozlowski
2025-04-14 13:28 ` [PATCH 3/3] leds: add WL-ICLED SPI driver Ante Knezic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174464444574.455759.7081664205185002557.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=ante.knezic@helmholz.de \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=knezic@helmholz.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox