From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7214C433EF for ; Thu, 9 Dec 2021 12:11:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231140AbhLIMPc (ORCPT ); Thu, 9 Dec 2021 07:15:32 -0500 Received: from sin.source.kernel.org ([145.40.73.55]:58642 "EHLO sin.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbhLIMPc (ORCPT ); Thu, 9 Dec 2021 07:15:32 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 6F19DCE245E; Thu, 9 Dec 2021 12:11:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91081C004DD; Thu, 9 Dec 2021 12:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639051915; bh=eADAqHBHTP/5lSMqidzF7Ig4xxyADIO5diu1cFOnGJM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=u3fpslFhOojJ+h1yBp50Bj7N+TWTKO+rsdU8WRhRlLyd02SACv4tdNI2bDS9Lmg7q VNSHRBBDr8hlgntOALHnp5TAbbbfNfLUM/jHXG2YA3Tdb829AQchsjcII6p0awT68s 39k9N3hoV7o3jv++6b+LjGz99HTDtrAjoTkhMlBWl1sK/Yxu8utapE5defIH1QJrJP T6bxV+Tfp1EX1F3ofwMfhxha9tVXeJH/+as8pS5X0j92AM/wjfBfkBTjVWpdrj3DGW +WNGKTVVGCjr9pQ51o07N75XyBRpV3MIVRCp3m+Fz3Bv1jroF8Kc6+ngDTpPvBWKK/ 6+Yq2t+V85OPA== Subject: Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios' To: Miquel Raynal Cc: Rob Herring , Richard Weinberger , Vignesh Raghavendra , Tony Lindgren , devicetree@vger.kernel.org, Thierry Reding , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211206174209.2297565-1-robh@kernel.org> <20211209104224.41d42cca@xps13> <20211209114038.710139a8@xps13> From: Roger Quadros Message-ID: <1744af96-3b71-3d41-12e2-a9052684cb35@kernel.org> Date: Thu, 9 Dec 2021 14:11:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211209114038.710139a8@xps13> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Miquel, On 09/12/2021 12:40, Miquel Raynal wrote: > Hi Roger, > > rogerq@kernel.org wrote on Thu, 9 Dec 2021 12:08:07 +0200: > >> Hi Miquel, >> >> On 09/12/2021 11:42, Miquel Raynal wrote: >>> Hi Rob, >>> >>> robh@kernel.org wrote on Mon, 6 Dec 2021 11:42:09 -0600: >>> >>>> With 'unevaluatedProperties' support implemented, the TI GPMC example >>>> has a warning: >>>> >>>> Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected) >>>> >>>> Add the missing definition for 'rb-gpios'. >>> >>> rb-gpios is already defined in nand-controller.yaml. I seems like the >>> real problem is that this file does not refer to it. Can you update the >>> fix? >> >> I don't think we can refer to nand-controller.yaml right now as we are not >> fully compatible with it yet. Please see examples below. > > This is a *very* wrong way of defining a NAND setup. I will take the > patch to silence the warning, but please convert this representation to Thanks! > the 'new' one. I believe on the driver side it should not be too > complicated to support having a few of these properties moved to a NAND > chip subnode and still support the below binding. Just be very clear > that if the legacy bindings are used, only a single chip is supported. I agree with you. It has been that way since ages. I will look at cleaning it up whenever possible for me. I think we will have to support the old bindings as well as the new one going forward as many legacy platforms are using it. cheers, -roger > >> ti,gpmc-nand example: >> >> nand@0,0 { >> compatible = "ti,omap2-nand"; >> reg = <0 0 4>; /* device IO registers */ >> interrupt-parent = <&gpmc>; >> interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */ >> <1 IRQ_TYPE_NONE>; /* termcount */ >> ti,nand-xfer-type = "prefetch-dma"; >> ti,nand-ecc-opt = "bch16"; >> ti,elm-id = <&elm>; >> #address-cells = <1>; >> #size-cells = <1>; >> >> /* NAND generic properties */ >> nand-bus-width = <8>; >> rb-gpios = <&gpmc 0 GPIO_ACTIVE_HIGH>; /* gpmc_wait0 */ >> >> /* GPMC properties*/ >> gpmc,device-width = <1>; >> >> partition@0 { >> label = "NAND.SPL"; >> reg = <0x00000000 0x00040000>; >> }; >> partition@1 { >> label = "NAND.SPL.backup1"; >> reg = <0x00040000 0x00040000>; >> }; >> }; >> >> >> nand-controller example: >> >> nand-controller { >> #address-cells = <1>; >> #size-cells = <0>; >> cs-gpios = <0>, <&gpioA 1>; /* A single native CS is available */ >> >> /* controller specific properties */ >> >> nand@0 { >> reg = <0>; /* Native CS */ >> nand-use-soft-ecc-engine; >> nand-ecc-algo = "bch"; >> >> /* controller specific properties */ >> }; >> >> nand@1 { >> reg = <1>; /* GPIO CS */ >> }; >> }; >> >> >>> >>> While at it you might also want to drop the rb-gpios property from >>> ingenic,nand.yaml, which also defines it a second time. >>> >>>> Cc: Miquel Raynal >>>> Cc: Richard Weinberger >>>> Cc: Vignesh Raghavendra >>>> Cc: Tony Lindgren >>>> Cc: Roger Quadros >>>> Cc: linux-mtd@lists.infradead.org >>>> Signed-off-by: Rob Herring >>>> --- >>>> Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml >>>> index beb26b9bcfb2..1c280f52baa0 100644 >>>> --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml >>>> +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml >>>> @@ -53,6 +53,11 @@ properties: >>>> enum: [8, 16] >>>> default: 8 >>>> >>>> + rb-gpios: >>>> + description: >>>> + GPIO connection to R/B signal from NAND chip >>>> + maxItems: 1 >>>> + >>>> patternProperties: >>>> "@[0-9a-f]+$": >>>> $ref: "/schemas/mtd/partitions/partition.yaml" >>> >>> Thanks, >>> Miquèl >>> >> >> cheers, >> -roger >> > > Thanks, > Miquèl >