From: Michael Walle <michael@walle.cc>
To: Claudiu.Beznea@microchip.com
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
Cristian.Birsan@microchip.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port
Date: Wed, 06 Jul 2022 10:57:33 +0200 [thread overview]
Message-ID: <1747f5d89ca65a9e54d95e7dd77c4709@walle.cc> (raw)
In-Reply-To: <32a2193f-aea1-6237-a993-d0ba89cce431@microchip.com>
Hi Claudiu,
Am 2022-07-06 10:41, schrieb Claudiu.Beznea@microchip.com:
> On 05.07.2022 16:06, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>> the content is safe
>>
>> Now that there is driver support for the USB device, enable it.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> index 5a6c5f7c371a..d0d26e136c38 100644
>> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> @@ -200,6 +200,11 @@ &switch {
>> status = "okay";
>> };
>>
>> +&udc {
>> + atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
>
> Can you also add pinctrl to avoid issues described in:
Do I need a pinctrl node even if I just use it as a gpio?
Isn't that handled automatically by the
.gpio_request_enable op?
-michael
next prev parent reply other threads:[~2022-07-06 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 13:06 [PATCH 1/2] ARM: dts: lan966x: add clock gating register Michael Walle
2022-07-05 13:06 ` [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port Michael Walle
2022-07-06 8:41 ` Claudiu.Beznea
2022-07-06 8:57 ` Michael Walle [this message]
2022-07-07 9:18 ` Claudiu.Beznea
2022-07-07 11:06 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1747f5d89ca65a9e54d95e7dd77c4709@walle.cc \
--to=michael@walle.cc \
--cc=Claudiu.Beznea@microchip.com \
--cc=Cristian.Birsan@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).