From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC310C433EF for ; Mon, 7 Mar 2022 17:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235527AbiCGRWS (ORCPT ); Mon, 7 Mar 2022 12:22:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230226AbiCGRWR (ORCPT ); Mon, 7 Mar 2022 12:22:17 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EBA690FDC for ; Mon, 7 Mar 2022 09:21:22 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id q7-20020a7bce87000000b00382255f4ca9so11269364wmj.2 for ; Mon, 07 Mar 2022 09:21:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IAk3PhzzFGV0B1v2wNJhqD7ncx2tZ/E4HW4CrzZxjvg=; b=PaUpUTCA0A/A6CIulO0e7HGJdVj9N3rHXbHC+6DwVntIWt976EdU4JtWRGZoHOFEmY QyQuNyKQPGcd6ddGTOVXKN1vcXREQKFtN2iGHK8V9SMP/TOcbBbjVSIoG4UlfCOP0eyG CmirCDFq8NZKvgRXAOYEpf4h7PMAwQeEvbjzKZfwdznPxFjgBS8cNk8/r5O7izqwifii VW885WGpyvZFIGLk2fH2p+CP7cO3PCn4V5584kMNi/coIXAzvxmddup9dlzLGn1y5HVx U06uaPPHJbkPqDO390ZOcLvrp3fnwqhi9t9w+tBH13TimxNj3HZBsn8V/gb9r38C2fmh 9mew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IAk3PhzzFGV0B1v2wNJhqD7ncx2tZ/E4HW4CrzZxjvg=; b=cxqAej+ZRaqRUZmpo3/e0q+tVG4QeTZEH9H89obGuXG02P5U9ZUpiT3G3KBMJWQUwv xo7AFkgvTo3k547QKYpRQuCZVKbToI/bisEc//oEgrii/6gofB8WEYpmCThZFGvTSohj fge5LzMMQeL5LrMmdvhxl5N9ky4K3V/Cw/cDUXzi89T4vXoIQoognVb1I4hhuZzFPEsM rbEGiMYg5iVYdhBg5INKKIkdPzBqDa/NHaMV7AoSEd4G0CUsC3PiuMRPN1tTcD0NLqTo laGdzt1S60L6k8KvSWNkAfs/5MzgTzFqgPA881A7tUFGLlZuYMgRtCm0M5CZWfKFBSOY h5Fw== X-Gm-Message-State: AOAM531bSs2wKisFlbBBUH+LqJul4loyWmLmnUvQs7Pwz3123LuZKkix i7Ao+csNvv/YLNvDjpYS3jvMCw== X-Google-Smtp-Source: ABdhPJwGMQtZ3E63B/mV0G4eYSgvz/jkQ7+cCCZeFbDF8//gLskmpO84n3wySVlfltI0QtSFVKGSqA== X-Received: by 2002:a1c:7c0a:0:b0:389:8d53:260e with SMTP id x10-20020a1c7c0a000000b003898d53260emr9662454wmc.69.1646673681048; Mon, 07 Mar 2022 09:21:21 -0800 (PST) Received: from ?IPV6:2a01:e34:ed2f:f020:6cbe:1901:15e:e188? ([2a01:e34:ed2f:f020:6cbe:1901:15e:e188]) by smtp.googlemail.com with ESMTPSA id m3-20020a5d6a03000000b001f06621641fsm9794789wru.96.2022.03.07.09.21.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Mar 2022 09:21:20 -0800 (PST) Message-ID: <174e42ce-13c7-e7ba-0ce8-227979383db1@linaro.org> Date: Mon, 7 Mar 2022 18:21:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 2/2] clocksource: Add Intel Keem Bay timer support Content-Language: en-US To: shruthi.sanil@intel.com, tglx@linutronix.de, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: andriy.shevchenko@linux.intel.com, mgross@linux.intel.com, srikanth.thokala@intel.com, lakshmi.bai.raja.subramanian@intel.com, mallikarjunappa.sangannavar@intel.com References: <20220307113147.19496-1-shruthi.sanil@intel.com> <20220307113147.19496-3-shruthi.sanil@intel.com> From: Daniel Lezcano In-Reply-To: <20220307113147.19496-3-shruthi.sanil@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/03/2022 12:31, shruthi.sanil@intel.com wrote: > From: Shruthi Sanil [ ... ] > + /* Prescaler bit must be enabled for the timer to function */ > + if (!(val & TIM_CONFIG_PRESCALER_ENABLE)) { > + pr_err("%pOF: FW_BUG: Prescaler is not enabled\n", np); > + ret = -ENODEV; return -ENODEV; > + } [ ... ] FW_BUG macro comment was already spotted -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog