From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Stephan Gerhold <stephan.gerhold@linaro.org>,
Saravana Kannan <saravanak@google.com>,
Rob Herring <robh@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
Georgi Djakov <djakov@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH 1/4] dt-bindings: mailbox: qcom,apcs: Add separate node for clock-controller
Date: Sat, 21 Jun 2025 13:51:16 -0700 [thread overview]
Message-ID: <175053907628.4372.13105365536734444855@lazor> (raw)
In-Reply-To: <jvsdn67x2qm2avaktnpqzoixcd46xuuf6i5kpeolsnewgoqt6q@jid7unlmmu65>
Quoting Bjorn Andersson (2025-06-10 20:31:57)
>
> I'm still sceptical here.
>
> In the first snippet above, we describe a single IP block which provides
> mailboxes and clocks.
>
> In the second snippet we're saying that the IP block is a mailbox, and
> then it somehow have a subcomponent which is a clock provider.
>
> It seems to me that we're choosing the second option because it better
> fits the Linux implementation, rather than that it would be a better
> representation of the hardware. To the point that we can't even describe
> the register range of the subcomponent...
>
Agreed. Don't workaround problems in the kernel by changing the binding
to have sub-nodes.
next prev parent reply other threads:[~2025-06-21 20:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 13:10 [PATCH 0/4] mailbox: qcom-apcs-ipc: Avoid circular dependency with clock controller Stephan Gerhold
2025-05-06 13:10 ` [PATCH 1/4] dt-bindings: mailbox: qcom,apcs: Add separate node for clock-controller Stephan Gerhold
2025-05-11 22:48 ` Bjorn Andersson
2025-05-13 13:16 ` Stephan Gerhold
2025-05-14 16:08 ` Rob Herring
2025-05-14 21:12 ` Stephan Gerhold
2025-05-21 9:20 ` Krzysztof Kozlowski
2025-05-22 19:53 ` Stephan Gerhold
2025-05-23 9:06 ` Krzysztof Kozlowski
2025-05-23 9:29 ` Stephan Gerhold
2025-06-11 3:31 ` Bjorn Andersson
2025-06-11 6:30 ` Krzysztof Kozlowski
2025-06-21 20:51 ` Stephen Boyd [this message]
2025-06-23 13:17 ` Stephan Gerhold
2025-07-17 17:30 ` Bjorn Andersson
2025-05-23 8:42 ` Krzysztof Kozlowski
2025-05-23 8:59 ` Stephan Gerhold
2025-05-23 9:07 ` Krzysztof Kozlowski
2025-05-06 13:10 ` [PATCH 2/4] mailbox: qcom-apcs-ipc: Assign OF node to clock controller child device Stephan Gerhold
2025-05-26 19:47 ` Jassi Brar
2025-05-28 19:21 ` Dmitry Baryshkov
2025-05-06 13:10 ` [PATCH 3/4] clk: qcom: apcs-msm8916: Obtain clock from own OF node Stephan Gerhold
2025-05-06 13:10 ` [PATCH 4/4] clk: qcom: apcs-sdx55: " Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175053907628.4372.13105365536734444855@lazor \
--to=sboyd@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).