public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: philippe baetens <philippebaetens@gmail.com>
Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org,
	 linux-kernel@vger.kernel.org, conor+dt@kernel.org,
	krzk+dt@kernel.org,  mchehab@kernel.org
Subject: Re: [PATCH v3 1/2] Add bindings for ams Mira220 cmos image sensor
Date: Tue, 01 Jul 2025 11:17:49 -0500	[thread overview]
Message-ID: <175138666987.1857452.9901567554592051735.robh@kernel.org> (raw)
In-Reply-To: <aGP67H5_GxL4z2Nc@raspberrypi>


On Tue, 01 Jul 2025 17:12:44 +0200, philippe baetens wrote:
> Mira220 is a global shutter NIR-enhanced image sensor made by AMS.
> Driver is submitted in the next patch of this series and verified on a raspberry pi.
> 
> Signed-off-by: philippe baetens <philippebaetens@gmail.com>
> ---
> Changes in v3:
> 	 - Improve commit message
> 	 - add mailing list for device tree.
> 
> Changes in v2:
> 	 - add maintainers and Documentation.yaml
> 
> ---
>  .../bindings/media/i2c/ams,mira220.yaml       | 125 ++++++++++++++++++
>  MAINTAINERS                                   |   6 +
>  2 files changed, 131 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/media/i2c/ams,mira220.example.dts:24.39-42.15: Warning (i2c_bus_reg): /example-0/i2c/camera-sensor@1a: I2C bus unit address format error, expected "54"
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ams,mira220.example.dtb: camera-sensor@1a (ams,mira220): 'vana-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/i2c/ams,mira220.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ams,mira220.example.dtb: camera-sensor@1a (ams,mira220): clock-names:0: 'inck' was expected
	from schema $id: http://devicetree.org/schemas/media/i2c/ams,mira220.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/aGP67H5_GxL4z2Nc@raspberrypi

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-07-01 16:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-01 15:12 [PATCH v3 1/2] Add bindings for ams Mira220 cmos image sensor philippe baetens
2025-07-01 16:17 ` Rob Herring (Arm) [this message]
2025-07-02  7:04 ` Krzysztof Kozlowski
2025-07-02  7:05 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175138666987.1857452.9901567554592051735.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=philippebaetens@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox