From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7405E234984; Mon, 14 Jul 2025 07:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752479334; cv=none; b=mASaNDx4sQopNCTAub7Pb3MzyMRkX73y8up7McOXJqKoopbjwToMuv/lhqQAq7ctVAUjlNF6EEEod1aash3ijDRpgTTBOxgyHGfhA1kxsBUiRGWjK7iG+NPkuRmOC5sgOd6bAH7ptqGffLPs97HKuh7MSTalG84yewxnt3wNIWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752479334; c=relaxed/simple; bh=nuuLlOVlNodzu/Axt3T1Z83fbyu4TP/XpSIuqgqPUrs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=Co/fwP16cei5U5jTgZf3AghxrDWAhxW+9qDUtVOHYtTO8xn5gyPuj9RZLzPJbGkr4/UAd1QA49FY4N+EYEDd+Y4W2X7xWva/0+KNLvuZ1okfPSR8pHVJX6tPrdF/PB4lY9A8KWpIBWwSnLrr3iGLHvp5HssmLfUBs24bidVGPfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=UjwWrKuM; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="UjwWrKuM" Received: by linux.microsoft.com (Postfix, from userid 1158) id CBE14201BA10; Mon, 14 Jul 2025 00:48:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CBE14201BA10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1752479327; bh=lh7OvjxUiWbA9fCP4WGF/thBMgI0OVrgL7zIDa8EjXs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UjwWrKuMn2J8yaJ5VSUTFtlQMDMxlzOO1Ga4sTrbHPJ2cjNj/uRzoDwcubCacpylX PpUi2p/sY9rvnQlMH2TSnl0OEqVWOvgDcSWq/nH6F5Flbv6BUkrP6FQyPDqSu7P0+F u0ZB3gMU6QoBnNGQ5uMODBGiHnm9ylBBB4ij6NBk= From: Hardik Garg To: krzk@kernel.org Cc: apais@microsoft.com, conor+dt@kernel.org, decui@microsoft.com, devicetree@vger.kernel.org, haiyangz@microsoft.com, hargar@linux.microsoft.com, hargar@microsoft.com, krzk+dt@kernel.org, kys@microsoft.com, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org, ssengar@linux.microsoft.com, wei.liu@kernel.org Subject: Re: [PATCH v4 1/2] dt-bindings: microsoft: Add vmbus message-connection-id property Date: Mon, 14 Jul 2025 00:48:47 -0700 Message-Id: <1752479327-19753-1-git-send-email-hargar@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <20250620-strange-rough-gharial-d2bc73@kuoka> References: <20250620-strange-rough-gharial-d2bc73@kuoka> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your review, Krzysztof. I apologize for the delay in my response. >> What is a connection ID and why it cannot be inferred from existing >> system API? The connection-id determines which hypervisor communication channel the guest should use to talk to the VMBus host. Reading from DeviceTree allows platforms to specify their preferred communication channel, making it more flexible (I will add this detail in the commit message). Presently, this value is hardcoded and there is no existing API to read it. >> There's a reason why you have here generic property - this is generic >> and/or discoverable and/or whatever software interface. Adding now more >> properties, just because you made it generic, is not the way. Presently the value is hardcoded and we want to provide a functionality to the user to specify their prefered communication channel. This is a virtualized hardware property for us. >> Drop | I will remove "|". >> Missing constraints, defaults, if this stays, but frankly speaking it >> looks really not appropriate, considering lack of any explanation in the >> binding or in commit msg. I will add constraints, and defaults. Please let me know if there are any other issues that I should fix with the next version of the patch and thank you again for the review. Regards, Hardik