public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Alicja Michalska <alicja.michalska@9elements.com>
Cc: simona@ffwll.ch, tzimmermann@suse.de, neil.armstrong@linaro.org,
	 maarten.lankhorst@linux.intel.com,
	dri-devel@lists.freedesktop.org,  devicetree@vger.kernel.org,
	mripard@kernel.org, quic_jesszhan@quicinc.com,
	 conor+dt@kernel.org, krzk+dt@kernel.org, airlied@gmail.com
Subject: Re: [PATCH 1/3] dt-bindings: display: panel: Add Samsung EA8076 panel
Date: Wed, 23 Jul 2025 15:14:33 -0500	[thread overview]
Message-ID: <175330167329.4381.10395843458101350582.robh@kernel.org> (raw)
In-Reply-To: <20250723145208.338162-2-alicja.michalska@9elements.com>


On Wed, 23 Jul 2025 16:52:08 +0200, Alicja Michalska wrote:
> Add bindings for Samsung EA8076 LCD panel.
> This panel was usually used in mid-high end smartphones manufactured by
> Xiaomi in 2018 and 2019 (Mi 9 Lite and Mi Mix 3, with codenames
> "xiaomi-pyxis" and "xiaomi-perseus", respectively).
> 
> Signed-off-by: Alicja Michalska <alicja.michalska@9elements.com>
> ---
>  .../display/panel/samsung,ea8076.yaml         | 71 +++++++++++++++++++
>  1 file changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,ea8076.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/panel/samsung,ea8076.yaml:9:111: [warning] line too long (155 > 110 characters) (line-length)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/samsung,ea8076.yaml: ignoring, error in schema: properties: reset-gpios
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/samsung,ea8076.yaml: properties:port: 'Required on platforms using MDSS DSI (Qualcomm).' is not of type 'object', 'boolean'
	from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/samsung,ea8076.yaml: properties:te-gpios: 'VSync GPIO pin, usually GPIO_ACTIVE_LOW.' is not of type 'object', 'boolean'
	from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/samsung,ea8076.yaml: properties:reset-gpios: 'Reset GPIO pin, usually GPIO_ACTIVE_LOW.' is not of type 'object', 'boolean'
	from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/samsung,ea8076.yaml: properties:port: 'Required on platforms using MDSS DSI (Qualcomm).' is not of type 'object', 'boolean'
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/samsung,ea8076.yaml: properties:te-gpios: 'VSync GPIO pin, usually GPIO_ACTIVE_LOW.' is not of type 'object', 'boolean'
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/samsung,ea8076.yaml: properties:reset-gpios: 'Reset GPIO pin, usually GPIO_ACTIVE_LOW.' is not of type 'object', 'boolean'
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
Documentation/devicetree/bindings/display/panel/samsung,ea8076.example.dtb: /example-0/dsi/panel@0: failed to match any schema with compatible: ['samsung,ea8076']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250723145208.338162-2-alicja.michalska@9elements.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2025-07-23 20:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 14:52 [PATCH 1/3] dt-bindings: display: panel: Add Samsung EA8076 panel Alicja Michalska
2025-07-23 14:52 ` [PATCH 2/3] drm: panel: Add support for Samsung EA8076 AMOLED panel Alicja Michalska
2025-07-23 20:14 ` Rob Herring (Arm) [this message]
2025-07-24  7:51 ` [PATCH 1/3] dt-bindings: display: panel: Add Samsung EA8076 panel Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175330167329.4381.10395843458101350582.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alicja.michalska@9elements.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk+dt@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox