[PATCH v1 0/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE

[PATCH v1 0/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE

[Eric Gonçalves]

Add new device tree and binding for the Samsung Galaxy S20 FE
 4G/5G phone (SM-G980/SM-G981B)
It features 6GB/8GB of RAM, 128GB/256GB UFS and also has 4G/5G variants.
 For now, this device tree covers those variants as they have the same
 codename and RAM is assigned from the bootloader.

Best regards,
Eric

Eric Gonçalves (2):
  dt-bindings: arm: qcom: document r8q board binding
  arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE

 .../devicetree/bindings/arm/qcom.yaml         |  1 +
 arch/arm64/boot/dts/qcom/Makefile             |  1 +
 .../boot/dts/qcom/sm8250-samsung-r8q.dts      | 47 +++++++++++++++++++
 3 files changed, 49 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sm8250-samsung-r8q.dts

-- 
2.50.1

[PATCH v1 1/2] dt-bindings: arm: qcom: document r8q board binding

[Eric Gonçalves]

Add binding for the Samsung Galaxy S20 FE 4G/5G (SM-G980/SM-G981B) board,
 codenamed R8Q,
which is based on the Qualcomm Snapdragon 865 SoC.

Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index ae43b3556580..607eee7a1794 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1076,6 +1076,7 @@ properties:
               - qcom,qrb5165-rb5
               - qcom,sm8250-hdk
               - qcom,sm8250-mtp
+              - samsung,r8q
               - sony,pdx203-generic
               - sony,pdx206-generic
               - xiaomi,elish
-- 
2.50.1

[PATCH v1 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE

[Eric Gonçalves]

Add new device support for the Samsung Galaxy S20 FE 4G/5G
 (SM-G980/SM-G981B) phone

What works:
- SimpleFB
- Pstore/ramoops

Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
---
 arch/arm64/boot/dts/qcom/Makefile             |  1 +
 .../boot/dts/qcom/sm8250-samsung-r8q.dts      | 47 +++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sm8250-samsung-r8q.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 4bfa926b6a08..5ac6aab51a9d 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -275,6 +275,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8150-sony-xperia-kumano-bahamut.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8150-sony-xperia-kumano-griffin.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-hdk.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-mtp.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-samsung-r8q.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx203.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx206.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-xiaomi-elish-boe.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-r8q.dts b/arch/arm64/boot/dts/qcom/sm8250-samsung-r8q.dts
new file mode 100644
index 000000000000..32036fc9668a
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-r8q.dts
@@ -0,0 +1,47 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+/dts-v1/;
+
+#include "sm8250.dtsi"
+
+/ {
+	model = "Samsung Galaxy S20 FE";
+	compatible = "samsung,r8q", "qcom,sm8250";
+	chassis-type = "handset";
+
+	chosen {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		framebuffer: framebuffer@9c000000 {
+			compatible = "simple-framebuffer";
+			reg = <0x0 0x9c000000 0x0 (1080 * 2400 * 4)>;
+			width = <1080>;
+			height = <2400>;
+			stride = <(1080 * 4)>;
+			format = "a8r8g8b8";
+		};
+	};
+
+	reserved-memory {
+		cont_splash_mem: memory@9c000000 {
+			reg = <0x0 0x9c000000 0x0 (1080 * 2400 * 4)>;
+			no-map;
+		};
+
+		ramoops@9fa00000 {
+			compatible = "ramoops";
+			reg = <0x0 0x9fa00000 0x0 0x100000>;
+			record-size = <0x4000>;
+			console-size = <0x40000>;
+			pmsg-size = <0x40000>;
+			ecc-size = <16>;
+			no-map;
+		};
+	};
+};
+
+&tlmm {
+	gpio-reserved-ranges = <40 4>; /* I2C (not linked to anything) */
+};
-- 
2.50.1

Re: [PATCH v1 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE

[Dmitry Baryshkov]

On Fri, Aug 15, 2025 at 03:14:26PM +0000, Eric Gonçalves wrote:
> Add new device support for the Samsung Galaxy S20 FE 4G/5G
>  (SM-G980/SM-G981B) phone
> 
> What works:
> - SimpleFB
> - Pstore/ramoops

While the patch is correct, are there any obstacles in enabling more
devices on the phone? I'd say, buttons, remoteprocs, PCI and USB
peripherals should be low hanging fruits. If you can read pmic_array
from debugfs/qcom_socinfo, then you should be able to identify PMICs and
add corresponding regulators too.

> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |  1 +
>  .../boot/dts/qcom/sm8250-samsung-r8q.dts      | 47 +++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sm8250-samsung-r8q.dts

-- 
With best wishes
Dmitry

Re: [PATCH v1 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE

[Eric Gonçalves]

On August 15, 2025 19:03:20 GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Fri, Aug 15, 2025 at 03:14:26PM +0000, Eric Gonçalves wrote:
>> Add new device support for the Samsung Galaxy S20 FE 4G/5G
>>  (SM-G980/SM-G981B) phone
>> 
>> What works:
>> - SimpleFB
>> - Pstore/ramoops
>
>While the patch is correct, are there any obstacles in enabling more
>devices on the phone? I'd say, buttons, remoteprocs, PCI and USB
>peripherals should be low hanging fruits. If you can read pmic_array
>from debugfs/qcom_socinfo, then you should be able to identify PMICs and
>add corresponding regulators too.
>
>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>> ---
>>  arch/arm64/boot/dts/qcom/Makefile             |  1 +
>>  .../boot/dts/qcom/sm8250-samsung-r8q.dts      | 47 +++++++++++++++++++
>>  2 files changed, 48 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/qcom/sm8250-samsung-r8q.dts
>
Hello Dmitry,

Recently my device's battery stopped responding and I was not able to work on the DT any further, so I decided to upstream what I already have so far. Thanks for the feedback, I'll include more features on future patches.

Best regards,
Eric

Re: [PATCH v1 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE

[Dmitry Baryshkov]

On Fri, Aug 15, 2025 at 08:28:32PM -0300, Eric Gonçalves wrote:
> 
> 
> On August 15, 2025 19:03:20 GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote:
> >On Fri, Aug 15, 2025 at 03:14:26PM +0000, Eric Gonçalves wrote:
> >> Add new device support for the Samsung Galaxy S20 FE 4G/5G
> >>  (SM-G980/SM-G981B) phone
> >> 
> >> What works:
> >> - SimpleFB
> >> - Pstore/ramoops
> >
> >While the patch is correct, are there any obstacles in enabling more
> >devices on the phone? I'd say, buttons, remoteprocs, PCI and USB
> >peripherals should be low hanging fruits. If you can read pmic_array
> >from debugfs/qcom_socinfo, then you should be able to identify PMICs and
> >add corresponding regulators too.
> >
> >> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> >> ---
> >>  arch/arm64/boot/dts/qcom/Makefile             |  1 +
> >>  .../boot/dts/qcom/sm8250-samsung-r8q.dts      | 47 +++++++++++++++++++
> >>  2 files changed, 48 insertions(+)
> >>  create mode 100644 arch/arm64/boot/dts/qcom/sm8250-samsung-r8q.dts
> >
> Hello Dmitry,
> 
> Recently my device's battery stopped responding and I was not able to
> work on the DT any further, so I decided to upstream what I already
> have so far. Thanks for the feedback, I'll include more features on
> future patches.
> 

Thanks!

For this patch:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH v1 1/2] dt-bindings: arm: qcom: document r8q board binding

[Rob Herring (Arm)]

On Fri, 15 Aug 2025 15:14:25 +0000, Eric Gonçalves wrote:
> Add binding for the Samsung Galaxy S20 FE 4G/5G (SM-G980/SM-G981B) board,
>  codenamed R8Q,
> which is based on the Qualcomm Snapdragon 865 SoC.
> 
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH v1 0/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE

[Bjorn Andersson]

On Fri, 15 Aug 2025 15:14:24 +0000, Eric Gonçalves wrote:
> Add new device tree and binding for the Samsung Galaxy S20 FE
>  4G/5G phone (SM-G980/SM-G981B)
> It features 6GB/8GB of RAM, 128GB/256GB UFS and also has 4G/5G variants.
>  For now, this device tree covers those variants as they have the same
>  codename and RAM is assigned from the bootloader.
> 
> Best regards,
> Eric
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: arm: qcom: document r8q board binding
      commit: 5fa902fb5716f419915fdb11c6b7e62f5ba7d14f
[2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE
      commit: 6657fe9e9f23b1c61d0bcc14a3af732f92fdc19b

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>