From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/2] media: adv7604: fix bindings inconsistency for default-input Date: Fri, 16 Sep 2016 12:54:35 +0300 Message-ID: <1755939.A2nWVFYccr@avalon> References: <20160916093942.17213-1-ulrich.hecht+renesas@gmail.com> <20160916093942.17213-2-ulrich.hecht+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20160916093942.17213-2-ulrich.hecht+renesas@gmail.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: Ulrich Hecht Cc: hans.verkuil@cisco.com, niklas.soderlund@ragnatech.se, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, magnus.damm@gmail.com, william.towle@codethink.co.uk, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Ulrich, Thank you for the patch. On Friday 16 Sep 2016 11:39:41 Ulrich Hecht wrote: > The text states that default-input is an endpoint property, but in the > example it is a device property. The example makes more sense. You should explain why it makes more sense. Something along the lines of "The example makes more sense as the default input is a property of the chip, not of a particular port." With that changed, Reviewed-by: Laurent Pinchart > Signed-off-by: Ulrich Hecht > --- > Documentation/devicetree/bindings/media/i2c/adv7604.txt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/adv7604.txt > b/Documentation/devicetree/bindings/media/i2c/adv7604.txt index > 8337f75..9cbd92e 100644 > --- a/Documentation/devicetree/bindings/media/i2c/adv7604.txt > +++ b/Documentation/devicetree/bindings/media/i2c/adv7604.txt > @@ -34,6 +34,7 @@ The digital output port node must contain at least one > endpoint. Optional Properties: > > - reset-gpios: Reference to the GPIO connected to the device's reset pin. > + - default-input: Select which input is selected after reset. > > Optional Endpoint Properties: > > @@ -47,8 +48,6 @@ Optional Endpoint Properties: > If none of hsync-active, vsync-active and pclk-sample is specified the > endpoint will use embedded BT.656 synchronization. > > - - default-input: Select which input is selected after reset. > - > Example: > > hdmi_receiver@4c { -- Regards, Laurent Pinchart