devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Aleksandrs Vinarskis <alex@vinarskis.com>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
	 Jacopo Mondi <jacopo@jmondi.org>,
	 Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	 Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	 Daniel Thompson <danielt@kernel.org>,
	Hans de Goede <hansg@kernel.org>,
	 linux-media@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Daniel Thompson <daniel.thompson@linaro.org>,
	 Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 Jingoo Han <jingoohan1@gmail.com>,
	linux-leds@vger.kernel.org,  dri-devel@lists.freedesktop.org,
	Pavel Machek <pavel@kernel.org>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: leds: add generic LED consumer documentation
Date: Fri, 05 Sep 2025 10:02:56 -0500	[thread overview]
Message-ID: <175708448034.930549.7632913810070724509.robh@kernel.org> (raw)
In-Reply-To: <20250905-leds-v2-1-ed8f66f56da8@vinarskis.com>


On Fri, 05 Sep 2025 09:59:29 +0200, Aleksandrs Vinarskis wrote:
> Introduce common generic led consumer binding, where consumer defines
> led(s) by phandle, as opposed to trigger-source binding where the
> trigger source is defined in led itself.
> 
> Add already used in some schemas 'leds' parameter which expects
> phandle-array. Additionally, introduce 'led-names' which could be used
> by consumers to map LED devices to their respective functions.
> 
> Signed-off-by: Aleksandrs Vinarskis <alex@vinarskis.com>
> ---
>  .../devicetree/bindings/leds/leds-consumer.yaml    | 85 ++++++++++++++++++++++
>  1 file changed, 85 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-consumer.example.dtb: camera@36 (ovti,ov02c10): Unevaluated properties are not allowed ('led-names', 'leds' were unexpected)
	from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov02e10.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250905-leds-v2-1-ed8f66f56da8@vinarskis.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2025-09-05 15:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05  7:59 [PATCH v2 0/4] leds: privacy-led support for devicetree Aleksandrs Vinarskis
2025-09-05  7:59 ` [PATCH v2 1/4] dt-bindings: leds: add generic LED consumer documentation Aleksandrs Vinarskis
2025-09-05 10:20   ` Konrad Dybcio
2025-09-05 15:02   ` Rob Herring (Arm) [this message]
2025-09-05 15:17   ` Rob Herring
2025-09-05 15:34     ` Rob Herring
2025-09-05  7:59 ` [PATCH v2 2/4] dt-bindings: leds: commonize leds property Aleksandrs Vinarskis
2025-09-05 15:24   ` Rob Herring
2025-09-05 16:48     ` Aleksandrs Vinarskis
2025-09-05 23:02       ` Rob Herring
2025-09-05  7:59 ` [PATCH v2 3/4] leds: led-class: Add devicetree support to led_get() Aleksandrs Vinarskis
2025-09-05  9:58   ` Andy Shevchenko
2025-09-05  7:59 ` [PATCH v2 4/4] arm64: dts: qcom: sc8280xp-x13s: enable camera privacy indicator Aleksandrs Vinarskis
2025-09-05 10:21   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175708448034.930549.7632913810070724509.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alex@vinarskis.com \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.thompson@linaro.org \
    --cc=danielt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hansg@kernel.org \
    --cc=jacopo@jmondi.org \
    --cc=jingoohan1@gmail.com \
    --cc=jjhiblot@traphandler.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pavel@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).