From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 828C9309F09; Fri, 5 Sep 2025 15:02:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757084577; cv=none; b=jl/pwDTupAWNBXBZ82/oE1XNzvt6MdIzraqzyTcW0PbLKJHSK5gHOMApCBCVviUI0jSLKaBqquCEo1Eu8sjJph3dWuuuYymmlF3SMBsJXigum5PST8fC+t8DYvsxSQGOMFutg81mFHypKonWXHeWOEI0ksSsFIxKsg8KEmy6GUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757084577; c=relaxed/simple; bh=0tSTOuBy2edUU22nf2u/6hjfDK4cj0VMfFcTtP7ysrY=; h=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References: Message-Id:Subject; b=bTi+4/IiNPZAuyJcxxesoEjPRNAJBQgKpuptcl4I/cHd1hArlvibkyM0oLfInNTfdYcPGrrOi+WErpZnlqHRrwq1oun6Uc+SDseLML+wH0ItxNo8Ie+8VATXY6CiXzGmDAWfuJ7AzuXApu2mRGqmKvVQ9jZFSbDo2LCKSFrEHN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j6Jgl871; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j6Jgl871" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F108EC4CEF1; Fri, 5 Sep 2025 15:02:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757084577; bh=0tSTOuBy2edUU22nf2u/6hjfDK4cj0VMfFcTtP7ysrY=; h=Date:From:Cc:To:In-Reply-To:References:Subject:From; b=j6Jgl871ZpOGLLTVIGzZAbMETn7GA9+trGgNUUA2jiCbTiQJLwJcSrdD1PCH+4lLj JM3MKCro/j4AU0DKFB2la6zhfv+7RlZzKxoO941U42scBfrYKi9uKfg3dkplvZIWcW 7vOfR7Agjjoe7mDcpcElnCfxrudzh7wcTLPhk2JKsoRrYHfcbXMu+Xc2ErXX9RWfm+ 7EFZxP+46sNGrLn3w2BSSDIOteP/dxgTGfqqFkkGGipddPlZY1RK3m+EZmfblbmytM OQbgRbyx1yIg/v4z66o1S1CoCwGzFcfOQa/cUhe4FOzO4pxz13P/UJ0EulOvY9Y9d1 knm2JLTAQvWCw== Date: Fri, 05 Sep 2025 10:02:56 -0500 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Jacopo Mondi , Jean-Jacques Hiblot , Sakari Ailus , Bjorn Andersson , Konrad Dybcio , Daniel Thompson , Hans de Goede , linux-media@vger.kernel.org, Krzysztof Kozlowski , Daniel Thompson , Bryan O'Donoghue , Jingoo Han , linux-leds@vger.kernel.org, dri-devel@lists.freedesktop.org, Pavel Machek , Mauro Carvalho Chehab , Conor Dooley To: Aleksandrs Vinarskis In-Reply-To: <20250905-leds-v2-1-ed8f66f56da8@vinarskis.com> References: <20250905-leds-v2-0-ed8f66f56da8@vinarskis.com> <20250905-leds-v2-1-ed8f66f56da8@vinarskis.com> Message-Id: <175708448034.930549.7632913810070724509.robh@kernel.org> Subject: Re: [PATCH v2 1/4] dt-bindings: leds: add generic LED consumer documentation On Fri, 05 Sep 2025 09:59:29 +0200, Aleksandrs Vinarskis wrote: > Introduce common generic led consumer binding, where consumer defines > led(s) by phandle, as opposed to trigger-source binding where the > trigger source is defined in led itself. > > Add already used in some schemas 'leds' parameter which expects > phandle-array. Additionally, introduce 'led-names' which could be used > by consumers to map LED devices to their respective functions. > > Signed-off-by: Aleksandrs Vinarskis > --- > .../devicetree/bindings/leds/leds-consumer.yaml | 85 ++++++++++++++++++++++ > 1 file changed, 85 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/leds-consumer.example.dtb: camera@36 (ovti,ov02c10): Unevaluated properties are not allowed ('led-names', 'leds' were unexpected) from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov02e10.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250905-leds-v2-1-ed8f66f56da8@vinarskis.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.