From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org
Cc: Huacai Chen <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Hongliang Wang <wanghongliang@loongson.cn>
Subject: Re: [PATCH v2 5/7] LoongArch: dts: DeviceTree for Loongson-2K1000
Date: Tue, 15 Aug 2023 16:56:42 +0200 [thread overview]
Message-ID: <175ab37b-2b01-bd67-cfbc-914efc810a7f@linaro.org> (raw)
In-Reply-To: <dcd87b8934c9b9869ffb24b3c904905587dcaa42.1692088166.git.zhoubinbin@loongson.cn>
On 15/08/2023 10:51, Binbin Zhou wrote:
> Add DeviceTree file for Loongson-2K1000 processor, which integrates two
> 64-bit dual emission superscalar LA264 processor cores.
>
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
> arch/loongarch/boot/dts/Makefile | 3 +-
> .../boot/dts/loongson-2k1000-ref.dts | 217 +++++++++++
> arch/loongarch/boot/dts/loongson-2k1000.dtsi | 345 ++++++++++++++++++
> 3 files changed, 564 insertions(+), 1 deletion(-)
> create mode 100644 arch/loongarch/boot/dts/loongson-2k1000-ref.dts
> create mode 100644 arch/loongarch/boot/dts/loongson-2k1000.dtsi
>
> diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile
> index aa0b21d73d4e..dc0782315bed 100644
> --- a/arch/loongarch/boot/dts/Makefile
> +++ b/arch/loongarch/boot/dts/Makefile
> @@ -1,5 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> -dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb
> +dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb \
> + loongson-2k1000-ref.dtb
>
> obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .dtb.o, $(CONFIG_BUILTIN_DTB_NAME))
> diff --git a/arch/loongarch/boot/dts/loongson-2k1000-ref.dts b/arch/loongarch/boot/dts/loongson-2k1000-ref.dts
> new file mode 100644
> index 000000000000..950a2df4e33f
> --- /dev/null
> +++ b/arch/loongarch/boot/dts/loongson-2k1000-ref.dts
> @@ -0,0 +1,217 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2023 Loongson Technology Corporation Limited
> + */
> +
> +/dts-v1/;
> +
> +#include "loongson-2k1000.dtsi"
> +
> +/ {
> + compatible = "loongson,ls2k1000-ref", "loongson,ls2k1000";
> + model = "Loongson-2K1000 Reference Board";
> +
> + aliases {
> + serial0 = &uart0;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + bootargs = "earlycon";
> + };
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu-map {
> + cluster0 {
> + core0 {
> + cpu = <&cpu0>;
> + };
> + core1 {
> + cpu = <&cpu1>;
> + };
> + };
> + };
> +
> + cpu0: cpu@0 {
> + compatible = "loongson,la264";
> + device_type = "cpu";
> + reg= <0x0>;
> + clocks = <&clk LOONGSON2_NODE_CLK>;
> + };
> +
> + cpu1: cpu@1 {
> + compatible = "loongson,la264";
> + device_type = "cpu";
> + reg = <0x1>;
> + clocks = <&clk LOONGSON2_NODE_CLK>;
> + };
> + };
> +
> + memory@200000 {
> + device_type = "memory";
> + reg = <0x0 0x200000 0x0 0x6e00000>,
> + <0x0 0x08000000 0x0 0x7000000>,
> + <0x0 0x90000000 0x1 0xe0000000>;
> + };
> +
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + linux,cma {
> + compatible = "shared-dma-pool";
> + reusable;
> + size = <0x0 0x2000000>;
> + linux,cma-default;
> + };
> + };
> +
> + i2c-gpio-0 {
> + compatible = "i2c-gpio";
> + scl-gpios = <&gpio0 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + sda-gpios = <&gpio0 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <5>; /* ~100 kHz */
> + status = "disabled";
Disabled node in board, without comment providing a reason, is useless.
Drop the node or fix the status.
> + };
> +
> + i2c-gpio-1 {
> + compatible = "i2c-gpio";
> + scl-gpios = <&gpio0 33 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + sda-gpios = <&gpio0 32 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <5>; /* ~100 kHz */
> + status = "disabled";
Ditto
> + };
> +};
> +
> +&gmac0 {
> + status = "okay";
> +
> + phy-mode = "rgmii";
> + phy-handle = <&phy0>;
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
compatible is always the first property.
> + phy0: ethernet-phy@0 {
> + reg = <0>;
> + };
> + };
> +};
> +
> +&gmac1 {
> + status = "okay";
> +
> + phy-mode = "rgmii";
> + phy-handle = <&phy1>;
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
compatible is always the first property.
> + phy1: ethernet-phy@1 {
> + reg = <16>;
> + };
> + };
> +};
...
> +};
> diff --git a/arch/loongarch/boot/dts/loongson-2k1000.dtsi b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
> new file mode 100644
> index 000000000000..fc3bb6368a5e
> --- /dev/null
> +++ b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
> @@ -0,0 +1,345 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2023 Loongson Technology Corporation Limited
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/clock/loongson,ls2k-clk.h>
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + ref_100m: clock-ref-100m {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <100000000>;
> + clock-output-names = "ref_100m";
> + };
> +
> + cpuintc: interrupt-controller {
> + compatible = "loongson,cpu-interrupt-controller";
> + #interrupt-cells = <1>;
> + interrupt-controller;
> + };
> +
> + bus@10000000 {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + ranges = <0x0 0x10000000 0x0 0x10000000 0x0 0x10000000>,
> + <0x0 0x2000000 0x0 0x2000000 0x0 0x2000000>,
> + <0x0 0x20000000 0x0 0x20000000 0x0 0x10000000>,
> + <0x0 0x40000000 0x0 0x40000000 0x0 0x40000000>,
> + <0xfe 0x0 0xfe 0x0 0x0 0x40000000>;
> +
> + dma-coherent;
> +
> + liointc0: interrupt-controller@1fe01400 {
> + compatible = "loongson,liointc-2.0";
> + reg = <0x0 0x1fe01400 0x0 0x40>,
> + <0x0 0x1fe01040 0x0 0x8>,
> + <0x0 0x1fe01140 0x0 0x8>;
> + reg-names = "main", "isr0", "isr1";
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupt-parent = <&cpuintc>;
> + interrupts = <2>;
> + interrupt-names = "int0";
> + loongson,parent_int_map = <0xffffffff>, /* int0 */
> + <0x00000000>, /* int1 */
> + <0x00000000>, /* int2 */
> + <0x00000000>; /* int3 */
> + };
> +
> + liointc1: interrupt-controller@1fe01440 {
> + compatible = "loongson,liointc-2.0";
> + reg = <0x0 0x1fe01440 0x0 0x40>,
> + <0x0 0x1fe01048 0x0 0x8>,
> + <0x0 0x1fe01148 0x0 0x8>;
> + reg-names = "main", "isr0", "isr1";
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupt-parent = <&cpuintc>;
> + interrupts = <3>;
> + interrupt-names = "int1";
> + loongson,parent_int_map = <0x00000000>, /* int0 */
> + <0xffffffff>, /* int1 */
> + <0x00000000>, /* int2 */
> + <0x00000000>; /* int3 */
> + };
> +
> + global-utilities@1fe00000 {
> + compatible = "loongson,ls2k-chipid";
> + reg = <0x0 0x1fe00000 0x0 0x3ffc>;
> + little-endian;
> + };
> +
> + pctrl: pinctrl@1fe00420 {
> + compatible = "loongson,ls2k-pinctrl";
> + reg = <0x0 0x1fe00420 0x0 0x18>;
> + status = "disabled";
> + };
> +
> + clk: clock-controller@1fe00480 {
> + compatible = "loongson,ls2k-clk";
> + reg = <0x0 0x1fe00480 0x0 0x58>;
> + #clock-cells = <1>;
> + clocks = <&ref_100m>;
> + clock-names = "ref_100m";
> + status = "disabled";
> + };
> +
> + gpio0: gpio@1fe00500 {
> + compatible = "loongson,ls2k-gpio";
> + reg = <0x0 0x1fe00500 0x0 0x38>;
> + ngpios = <64>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + gpio-ranges = <&pctrl 0x0 0x0 15>,
> + <&pctrl 16 16 15>,
> + <&pctrl 32 32 10>,
> + <&pctrl 44 44 20>;
> + interrupt-parent = <&liointc1>;
> + interrupts = <28 IRQ_TYPE_LEVEL_HIGH>,
> + <29 IRQ_TYPE_LEVEL_HIGH>,
> + <30 IRQ_TYPE_LEVEL_HIGH>,
> + <30 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <26 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <>,
> + <>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>,
> + <27 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + uart0: serial@1fe20000 {
> + compatible = "ns16550a";
> + reg = <0x0 0x1fe20000 0x0 0x10>;
> + clock-frequency = <125000000>;
> + interrupt-parent = <&liointc0>;
> + interrupts = <0x0 IRQ_TYPE_LEVEL_HIGH>;
> + no-loopback-test;
> + status = "disabled";
> + };
> +
> + i2c2: i2c@1fe21000 {
> + compatible = "loongson,ls2k-i2c";
> + reg = <0x0 0x1fe21000 0x0 0x8>;
> + interrupt-parent = <&liointc0>;
> + interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> +
> + i2c3: i2c@1fe21800 {
> + compatible = "loongson,ls2k-i2c";
> + reg = <0x0 0x1fe21800 0x0 0x8>;
> + interrupt-parent = <&liointc0>;
> + interrupts = <23 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> +
> + rtc0: rtc@1fe27800 {
> + compatible = "loongson,ls2k1000-rtc";
> + reg = <0x0 0x1fe27800 0x0 0x100>;
> + interrupt-parent = <&liointc1>;
> + interrupts = <8 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> +
> + pcie@1a000000 {
> + compatible = "loongson,ls2k-pci";
> + device_type = "pci";
> + #size-cells = <2>;
> + #address-cells = <3>;
> +
> + reg = <0x0 0x1a000000 0x0 0x02000000>,
> + <0xfe 0x0 0x0 0x20000000>;
> +
> + ranges = <0x1000000 0x0 0x8000 0x0 0x18008000 0x0 0x8000>,
> + <0x2000000 0x0 0x60000000 0x0 0x60000000 0x0 0x20000000>; /* mem */
> +
> + gmac0: ethernet@3,0 {
> + reg = <0x1800 0x0 0x0 0x0 0x0>;
> + interrupt-parent = <&liointc0>;
> + interrupts = <12 IRQ_TYPE_LEVEL_HIGH>,
> + <13 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_lpi";
> + status = "disabled";
> + };
> +
> + gmac1: ethernet@3,1 {
> + reg = <0x1900 0x0 0x0 0x0 0x0>;
> + interrupt-parent = <&liointc0>;
> + interrupts = <14 IRQ_TYPE_LEVEL_HIGH>,
> + <15 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_lpi";
> + status = "disabled";
> + };
> +
> + ehci0: usb@4,1 {
> + reg = <0x2100 0x0 0x0 0x0 0x0>;
> + interrupt-parent = <&liointc1>;
> + interrupts = <18 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
All these PCI devices are part of SoC? The SoC?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-15 14:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 8:50 [PATCH v2 0/7] LoongArch: Add built-in dtb support Binbin Zhou
2023-08-15 8:50 ` [PATCH v2 1/7] dt-bindings: loongarch: Add CPU bindings for LoongArch Binbin Zhou
2023-08-15 14:07 ` Conor Dooley
2023-08-16 6:37 ` Binbin Zhou
2023-08-16 6:50 ` Conor Dooley
2023-08-15 8:50 ` [PATCH v2 2/7] dt-bindings: loongarch: Add Loongson SoC boards compatibles Binbin Zhou
2023-08-15 14:13 ` Conor Dooley
2023-08-17 6:16 ` Binbin Zhou
2023-08-17 8:44 ` Conor Dooley
2023-08-17 8:46 ` Conor Dooley
2023-08-15 14:49 ` Krzysztof Kozlowski
2023-08-17 6:24 ` Binbin Zhou
2023-08-15 8:50 ` [PATCH v2 3/7] LoongArch: Allow device trees to be built into the kernel Binbin Zhou
2023-08-15 8:51 ` [PATCH v2 4/7] LoongArch: dts: DeviceTree for Loongson-2K0500 Binbin Zhou
2023-08-15 14:09 ` Conor Dooley
2023-08-17 3:15 ` Binbin Zhou
2023-08-15 14:48 ` Krzysztof Kozlowski
2023-08-17 5:36 ` Binbin Zhou
2023-08-15 8:51 ` [PATCH v2 5/7] LoongArch: dts: DeviceTree for Loongson-2K1000 Binbin Zhou
2023-08-15 14:56 ` Krzysztof Kozlowski [this message]
2023-08-17 6:41 ` Binbin Zhou
2023-08-15 8:51 ` [PATCH v2 6/7] LoongArch: dts: DeviceTree for Loongson-2K2000 Binbin Zhou
2023-08-15 8:51 ` [PATCH v2 7/7] LoongArch: Parsing CPU-related information from DTS Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175ab37b-2b01-bd67-cfbc-914efc810a7f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=robh+dt@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).