devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"David Heidelberg" <david@ixit.cz>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: adc: Add BD7910[0,1,2,3]
Date: Thu, 14 Aug 2025 12:57:07 +0300	[thread overview]
Message-ID: <175ce750-7f5d-477c-8d18-dd418ba749be@gmail.com> (raw)
In-Reply-To: <8ef78e3cffcfdf99153a3fcf57860771890f1632.1755159847.git.mazziesaccount@gmail.com>

On 14/08/2025 11:35, Matti Vaittinen wrote:
> The ROHM BD79100, BD79101, BD79102, BD79103 are very similar ADCs as the
> ROHM BD79104. The BD79100 has only 1 channel. BD79101 has 2 channels and
> the BD79102 has 4 channels. Both BD79103 and BD79104 have 4 channels,
> and, based on the data sheets, they seem identical from the software
> point-of-view.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
>   .../devicetree/bindings/iio/adc/rohm,bd79104.yaml     | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> index f0a1347ba4db..6a6e6ab4aca3 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
> @@ -14,7 +14,16 @@ description: |
>   
>   properties:
>     compatible:
> -    const: rohm,bd79104
> +    oneOf:
> +      - items:
> +          - enum:
> +              - rohm,bd79100
> +              - rohm,bd79101
> +              - rohm,bd79102
> +              - rohm,bd79104
> +      - items:
> +          - const: rohm,bd79104
> +          - const: rohm,bd79103

Oops. I believe the order of the compatibles is wrong for the fallback.

>   
>     reg:
>       maxItems: 1

Yours,
	-- Matti

  reply	other threads:[~2025-08-14  9:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-14  8:34 [PATCH 0/3] Support ROHM BD7910[0,1,2,3] Matti Vaittinen
2025-08-14  8:35 ` [PATCH 1/3] dt-bindings: iio: adc: Add BD7910[0,1,2,3] Matti Vaittinen
2025-08-14  9:57   ` Matti Vaittinen [this message]
2025-08-14 14:51     ` David Lechner
2025-08-15  5:00       ` Matti Vaittinen
2025-08-14  8:35 ` [PATCH 2/3] iio: adc: adc128s052: Simplify matching chip_data Matti Vaittinen
2025-08-14 14:53   ` David Lechner
2025-08-16 12:28     ` Jonathan Cameron
2025-08-16 12:32       ` Jonathan Cameron
2025-08-14  8:35 ` [PATCH 3/3] iio: adc: adc128s052: Support ROHM BD7910[0,1,2,3] Matti Vaittinen
2025-08-14 15:01   ` David Lechner
2025-08-15  5:23     ` Matti Vaittinen
2025-08-15 14:16       ` David Lechner
2025-08-15 14:17       ` David Lechner
2025-08-16 12:31         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175ce750-7f5d-477c-8d18-dd418ba749be@gmail.com \
    --to=mazziesaccount@gmail.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).