From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A74C6FA82 for ; Sat, 17 Sep 2022 14:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229688AbiIQOZm (ORCPT ); Sat, 17 Sep 2022 10:25:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbiIQOZj (ORCPT ); Sat, 17 Sep 2022 10:25:39 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FEE73335F; Sat, 17 Sep 2022 07:25:29 -0700 (PDT) Received: from [88.128.88.164] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oZYkz-0001LQ-HZ; Sat, 17 Sep 2022 16:25:21 +0200 From: Heiko Stuebner To: Jagan Teki Cc: Rob Herring , Krzysztof Kozlowski , Kever Yang , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Michael Turquette , Stephen Boyd , Finley Xiao Subject: Re: [PATCH v5 4/6] clk: rockchip: Add clock controller support for RV1126 SoC. Date: Sat, 17 Sep 2022 16:25:20 +0200 Message-ID: <1760564.3VsfAaAtOV@phil> In-Reply-To: References: <20220915163947.1922183-1-jagan@edgeble.ai> <2597191.BddDVKsqQX@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jagan, Am Samstag, 17. September 2022, 13:58:43 CEST schrieben Sie: > On Sat, 17 Sept 2022 at 12:25, Heiko Stuebner wrote: > > > > Am Donnerstag, 15. September 2022, 18:39:45 CEST schrieb Jagan Teki: > > > Clock & Reset Unit (CRU) in RV1126 support clocks for CRU > > > and CRU_PMU blocks. > > > > > > This patch is trying to add minimal Clock-Architecture Diagram's > > > inferred from [1] authored by Finley Xiao. > > > > > > [1] https://github.com/rockchip-linux/kernel/blob/develop-4.19/drivers/clk/rockchip/clk-rv1126.c > > > > > > Cc: linux-clk@vger.kernel.org > > > Cc: Michael Turquette > > > Cc: Stephen Boyd > > > Signed-off-by: Finley Xiao > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v5: > > > - add platform-drivers > > > > [...] > > > > > +static void __init rv1126_pmu_clk_init(struct device_node *np) > > > +{ > > > + struct rockchip_clk_provider *ctx; > > > + void __iomem *reg_base; > > > + > > > + reg_base = of_iomap(np, 0); > > > + if (!reg_base) { > > > + pr_err("%s: could not map cru pmu region\n", __func__); > > > + return; > > > + } > > > + > > > + ctx = rockchip_clk_init(np, reg_base, CLKPMU_NR_CLKS); > > > + if (IS_ERR(ctx)) { > > > + pr_err("%s: rockchip pmu clk init failed\n", __func__); > > > + return; > > > + } > > > + > > > + rockchip_clk_register_plls(ctx, rv1126_pmu_pll_clks, > > > + ARRAY_SIZE(rv1126_pmu_pll_clks), > > > + RV1126_GRF_SOC_STATUS0); > > > + > > > + rockchip_clk_register_branches(ctx, rv1126_clk_pmu_branches, > > > + ARRAY_SIZE(rv1126_clk_pmu_branches)); > > > + > > > + rockchip_register_softrst(np, 2, reg_base + RV1126_PMU_SOFTRST_CON(0), > > > + ROCKCHIP_SOFTRST_HIWORD_MASK); > > > + > > > + rockchip_clk_of_add_provider(np, ctx); > > > +} > > > + > > > +CLK_OF_DECLARE(rv1126_cru_pmu, "rockchip,rv1126-pmucru", rv1126_pmu_clk_init); > > > > this one and the one below should go away I think. > > > > Can you check if that is the case, then I can just drop the two > > CLK_OF_DECLARE lines. > > I think these are unneeded, it worked w/o these when I built a static. great to hear that, then I'll drop those > but others are still included. > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/clk/rockchip/clk-rk3568.c#n1636 > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/clk/rockchip/clk-rk3568.c#n1679 very likely. As I want to test such changes on hardware, I'm not removing them just now but will try to look at that once I'm back home from LPC/ELCE. Heiko