Devicetree
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	 Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
	 linux-arm-msm@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 linux-bluetooth@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	 devicetree@vger.kernel.org,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	 Marcel Holtmann <marcel@holtmann.org>,
	Rocky Liao <quic_rjliao@quicinc.com>
Subject: Re: [PATCH 02/12] dt-bindings: bluetooth: qcom,qca2066-bt: Split to separate schema
Date: Tue, 28 Oct 2025 12:29:07 -0500	[thread overview]
Message-ID: <176167254303.2794634.13957368391979283059.robh@kernel.org> (raw)
In-Reply-To: <20251028-dt-bindings-qcom-bluetooth-v1-2-524a978e3cda@linaro.org>


On Tue, 28 Oct 2025 16:31:51 +0100, Krzysztof Kozlowski wrote:
> One big Qualcomm Bluetooth schema is hardly manageable: it lists all
> possible properties (19 supplies).  Split common part and
> qcom,qca2066-bt to separate bindings, so each schema will be easier to
> read/maintain and list only relevant properties.
> 
> The existing bindings do not mention interrupts, but
> am335x-sancloud-bbe-extended-wifi.dts already defines such.  This issue
> is not being fixed here.
> 
> Existing binding also did not mention any supplies (which do exist as
> confirmed in datasheet) and Linux driver does not ask for any, thus keep
> this state unchanged.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Expected warnings:
> arch/arm/boot/dts/ti/omap/am335x-sancloud-bbe-extended-wifi.dts
> ---
>  .../net/bluetooth/qcom,bluetooth-common.yaml       | 25 +++++++++++
>  .../bindings/net/bluetooth/qcom,qca2066-bt.yaml    | 49 ++++++++++++++++++++++
>  .../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 24 -----------
>  MAINTAINERS                                        |  1 +
>  4 files changed, 75 insertions(+), 24 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Lexical error: Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.example.dts:53.42-58 Unexpected 'GPIO_ACTIVE_HIGH'
Lexical error: Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.example.dts:54.42-58 Unexpected 'GPIO_ACTIVE_HIGH'
FATAL ERROR: Syntax error parsing input tree
make[2]: *** [scripts/Makefile.dtbs:132: Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1528: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251028-dt-bindings-qcom-bluetooth-v1-2-524a978e3cda@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-10-28 17:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28 15:31 [PATCH 00/12] Bluetooth: dt-bindings: qualcomm: Split binding Krzysztof Kozlowski
2025-10-28 15:31 ` [PATCH 01/12] Bluetooth: MAINTAINERS: Orphan Qualcomm hci_qca Krzysztof Kozlowski
2025-10-28 15:43   ` Bartosz Golaszewski
2025-10-28 15:47     ` Krzysztof Kozlowski
2025-10-28 15:48       ` Bartosz Golaszewski
2025-10-28 15:31 ` [PATCH 02/12] dt-bindings: bluetooth: qcom,qca2066-bt: Split to separate schema Krzysztof Kozlowski
2025-10-28 17:29   ` Rob Herring (Arm) [this message]
2025-10-28 17:40     ` Krzysztof Kozlowski
2025-10-28 15:31 ` [PATCH 03/12] dt-bindings: bluetooth: qcom,qca9377-bt: " Krzysztof Kozlowski
2025-10-28 17:29   ` Rob Herring (Arm)
2025-10-28 15:31 ` [PATCH 04/12] dt-bindings: bluetooth: qcom,qca6390-bt: " Krzysztof Kozlowski
2025-10-28 17:29   ` Rob Herring (Arm)
2025-10-28 15:31 ` [PATCH 05/12] dt-bindings: bluetooth: qcom,wcn3950-bt: " Krzysztof Kozlowski
2025-10-28 17:29   ` Rob Herring (Arm)
2025-10-28 15:31 ` [PATCH 06/12] dt-bindings: bluetooth: qcom,wcn3990-bt: " Krzysztof Kozlowski
2025-10-28 17:29   ` Rob Herring (Arm)
2025-10-28 15:31 ` [PATCH 07/12] dt-bindings: bluetooth: qcom,wcn6750-bt: " Krzysztof Kozlowski
2025-10-28 15:31 ` [PATCH 08/12] dt-bindings: bluetooth: qcom,wcn6750-bt: Deprecate old supplies Krzysztof Kozlowski
2025-10-28 15:31 ` [PATCH 09/12] dt-bindings: bluetooth: qcom,wcn6855-bt: Split to separate schema Krzysztof Kozlowski
2025-10-28 15:31 ` [PATCH 10/12] dt-bindings: bluetooth: qcom,wcn6855-bt: Deprecate old supplies Krzysztof Kozlowski
2025-10-28 15:32 ` [PATCH 11/12] dt-bindings: bluetooth: qcom,wcn7850-bt: Split to separate schema Krzysztof Kozlowski
2025-10-28 15:32 ` [PATCH 12/12] dt-bindings: bluetooth: qcom,wcn7850-bt: Deprecate old supplies Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176167254303.2794634.13957368391979283059.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=quic_bgodavar@quicinc.com \
    --cc=quic_rjliao@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox