RE: [PATCH v5 1/2] dt-bindings: usb: ti,hd3ss3220: Add support for VBUS based on ID state

Biju Das
2025-10-27T08:44:52Z

> -----Original Message-----
> From: Krishna Kurapati PSSNV <krishna.kurapati@oss.qualcomm.com>
> Sent: 27 October 2025 08:32
> To: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: linux-usb@vger.kernel.org; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> Heikki Krogerus <heikki.krogerus@linux.intel.com>; Dmitry Baryshkov
> <dmitry.baryshkov@oss.qualcomm.com>; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v5 1/2] dt-bindings: usb: ti,hd3ss3220: Add support for VBUS based on ID state
>
>
>
> On 10/27/2025 1:02 PM, Biju Das wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> >> Sent: 27 October 2025 07:28
> > .kernel.org; linux-kernel@vger.kernel.org; Krishna
> >> Kurapati <krishna.kurapati@oss.qualcomm.com>
> >> Subject: [PATCH v5 1/2] dt-bindings: usb: ti,hd3ss3220: Add support
> >> for VBUS based on ID state
> >>
> >> Update the bindings to support reading ID state and VBUS, as per the
> >> HD3SS3220 data sheet. The ID pin is kept high if VBUS is not at
> >> VSafe0V and asserted low once VBUS is at VSafe0V, enforcing the Type-C requirement that VBUS must
> be at VSafe0V before re-enabling VBUS.
> >>
> >> Add id-gpios property to describe the input gpio for USB ID pin.
> >>
> >> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> >> ---
> >> Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> >> b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> >> index bec1c8047bc0..06099e93c6c3 100644
> >> --- a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> >> +++ b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.yaml
> >> @@ -25,6 +25,14 @@ properties:
> >> interrupts:
> >> maxItems: 1
> >>
> >> + id-gpios:
> >> + description:
> >> + An input gpio for USB ID pin. Upon detecting a UFP device, HD3SS3220
> >> + will keep ID pin high if VBUS is not at VSafe0V. Once VBUS is at VSafe0V,
> >> + the HD3SS3220 will assert ID pin low. This is done to enforce Type-C
> >> + requirement that VBUS must be at VSafe0V before re-enabling VBUS.
> >> + maxItems: 1
> >> +
> >
> > Maybe to help DT users, add an example for this use case??
> >
> Hi Biju,
>
> Adding GPIO to dt is a generic thing. Also this is an optional proprety. Can we skip adding an
> example.

OK for me. Just thought that example will cover regulator usage as well for DT user.

Cheers,
Biju